Add metadata key to GET /server response #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Dean,
Thanks for the PRs! I've not forgotten about them but Ii'm still heads down
on the meltdown/spectre mess and currently don't have time to look at the
PRs.
...Juerg
…On Mon, Dec 18, 2017 at 8:06 PM, Dean Troyer ***@***.***> wrote:
The metadata key is still present for backward-compatibility.
Signed-off-by: Dean Troyer ***@***.***
------------------------------
You can view, comment on, or merge this pull request online at:
#10
Commit Summary
- Add metadata key to GET /server response
File Changes
- *M* dwarf/compute/api_response.py
<https://github.com/juergh/dwarf/pull/10/files#diff-0> (3)
- *M* tests/api/test_compute_servers.py
<https://github.com/juergh/dwarf/pull/10/files#diff-1> (1)
Patch Links:
- https://github.com/juergh/dwarf/pull/10.patch
- https://github.com/juergh/dwarf/pull/10.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABH22tFOVDhCMYC3IqzmgELh4yEUUQpmks5tBrevgaJpZM4RF7kj>
.
|
|
No worries, hopefully these rebased PRs ones will be simpler to review rather than all in one. I have a few more in the queue... |
The metadata key is still present for backward-compatibility. Signed-off-by: Dean Troyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata key is still present for backward-compatibility.
Signed-off-by: Dean Troyer [email protected]