Skip to content

Commit

Permalink
Allow rbd mirroring mode to be set to none
Browse files Browse the repository at this point in the history
Allow the rbd-mirroring-mode for a Ceph pool to be specified as
'none'. This allows a charm to be able to explicitly disable rbd
mirroring when it knows it will be creating a pool type which is
not supported.

The example for this, is when erasure coded pools are being created
for RBD use. Two pools are created, one for erasure coded data and
one for RBD metadata. Neither pool should be mirrored, so the charm
can explicitly specify this.

Closes-Bug: #1898504
  • Loading branch information
wolsen committed Apr 3, 2021
1 parent 8c48d29 commit 4d8af76
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion charmhelpers/contrib/storage/linux/ceph.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ class BasePool(object):
'compression-max-blob-size': (int, None),
'compression-max-blob-size-hdd': (int, None),
'compression-max-blob-size-ssd': (int, None),
'rbd-mirroring-mode': (str, ('image', 'pool'))
'rbd-mirroring-mode': (str, ('image', 'pool', 'none'))
}

def __init__(self, service, name=None, percent_data=None, app_name=None,
Expand Down

0 comments on commit 4d8af76

Please sign in to comment.