std::math::big: fix signed integer conversion

julelang · Mar 2, 2024 · 963939c · 963939c
1 parent b252afc
commit 963939c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/std/math/big/int.jule b/std/math/big/int.jule
@@ -208,7 +208,10 @@ impl Int {
         }
         let x = i64(u64_from_bits(self.nat.bits))
         if self.neg {
-            ret i64.MIN + x
+            if x == 0 {
+                ret i64.MIN
+            }
+            ret -x
         }
         ret x
     }

diff --git a/std/math/big/nat.jule b/std/math/big/nat.jule
@@ -23,7 +23,7 @@ impl Nat {
 
     // Returns Nat that initialized by integer value.
     // T can only be signed or unsigned integer types.
-    pub static fn new[T](i: T): Nat {
+    pub static fn new[T](mut i: T): Nat {
         match type T {
         | Nat:
             ret i
@@ -53,6 +53,9 @@ impl Nat {
         |:
             panic("std::math::big: Nat.new[T]: T is should be signed or unsigned integer type")
         }
+        if i < 0 {
+            i = -i
+        }
         for j in nat.bits {
             nat.bits[j] = bit((i >> j) & 0b1)
         }