sema: improve array size error

julelang · Jun 15, 2024 · dc2db5b · dc2db5b
1 parent 0664faa
commit dc2db5b
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/std/jule/build/log.jule b/std/jule/build/log.jule
@@ -236,6 +236,7 @@ enum LogMsg: str {
     MissingArgs: `missing arguments to call @`,
     InheritedNonTrait: `trait @ cannot implement @, type should be trait`,
     IncompatibleInherit: "trait @ inherits trait @, but same identifiers implemented different;\n       @\n       @",
+    ArraySizeOverflow: "array with size @ overflows limit (@) of the system",
 
     // Suggestions.
     ExpectedIdentifier: `write an identifier because identifier expected`,

diff --git a/std/jule/sema/eval.jule b/std/jule/sema/eval.jule
@@ -4399,4 +4399,15 @@ fn pushSubIdentFromExpr(mut expr: ExprData, mut &t: &SubIdentTypeDecl): bool {
         ret false
     }
     ret true
+}
+
+fn constoa(&c: &Const): str {
+    match {
+    | c.IsI64():
+        ret conv::FmtInt(c.ReadI64(), 10)
+    | c.IsU64():
+        ret conv::FmtUint(c.ReadU64(), 10)
+    |:
+        ret ""
+    }
 }
diff --git a/std/jule/sema/type.jule b/std/jule/sema/type.jule
@@ -1277,9 +1277,13 @@ impl typeChecker {
             if n < 0 {
                 self.pushErr(decl.Elem.Token, LogMsg.ArraySizeIsNeg)
                 ret nil
-            } else if types::BitSize != 64 && f64(n) > types::Max(PrimKind.Int) {
-                self.pushErr(decl.Size.Token, LogMsg.OverflowLimits)
-                ret nil
+            } else {
+                let max = types::MaxI(PrimKind.Int)
+                if types::BitSize != 64 && i64(n) > max {
+                    self.pushErr(decl.Size.Token, LogMsg.ArraySizeOverflow,
+                        constoa(size.Constant), conv::FmtInt(max, 10))
+                    ret nil
+                }
             }
         }