-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jule: implement immutable strings #109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertcandav
added
compiler/runtime
Related with runtime
compiler
Related with compiler/compile-time
api
About API
labels
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements immutable strings for Jule. Primitive string type is mutable, which is performs copying and heap allocations, even for literals. The purpose is reduce copying and heap allocations for strings, especially for literals. Thus, program can share common allocation without allocate new copy of string because it's immutable.
For mutable strings and efficient concats, the
StrBuilder
struct added tostd::string
package. The+
operator is still supported for primitive string type, but it performs allocation without capacity, so is not efficient especially for big strings.The old implementation is C++ STL based, new implementation is Jule's RC based. It still guarantees NULL-terminated strings like C. So, using with Integrated Jule should be work as expected without any modification.
Performance
On my primary system (MacBook M2 Pro), average execution time of Jule compiler for whole Jule compiler source code is
~0.48s
, after immutable strings is~0.54s
. I think it is possible that this performance loss is due to the loss of optimizations that C++ STL offers forstd::basic_string
, which is used by old implementation. However, considered as reasonable performance lost. If it caused by bad handling of immutable strings, it will be improved at the future.Changelog
--opt-str
std::strings
: add theStrBuilder
jule::to_str<T>
function define declared asjule::to_str2<T>