Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use auto with static_cast #70

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Jan 31, 2024

Description

In these situations, explicitly describing the type of a defined variable is redundant. I suggest to use auto.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing tests pass.
  • The code follows the code style and conventions of the project.
  • No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
  • I have read the whole Contributing guidelines of the project and its resources/related pages.

Screenshots (if any)

Note to reviewers

Use auto when a variable is defined as a result of static_cast.

@mertcandav mertcandav self-requested a review January 31, 2024 20:17
@mertcandav mertcandav added the api About API label Jan 31, 2024
Copy link
Member

@mertcandav mertcandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@mertcandav mertcandav merged commit cb334fc into julelang:master Jan 31, 2024
4 checks passed
@vil02 vil02 deleted the use_auto branch January 31, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api About API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants