Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: avoid sign conversion in utf8_to_runes #72

Merged
merged 1 commit into from
Feb 1, 2024
Merged

style: avoid sign conversion in utf8_to_runes #72

merged 1 commit into from
Feb 1, 2024

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Feb 1, 2024

Description

Similar to #71. Please note the change of the signature of utf8_decode_rune_str.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing tests pass.
  • The code follows the code style and conventions of the project.
  • No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
  • I have read the whole Contributing guidelines of the project and its resources/related pages.

Screenshots (if any)

Note to reviewers

Avoid sign conversion in utf8_to_runes.

@mertcandav mertcandav self-requested a review February 1, 2024 18:08
@mertcandav mertcandav added the api About API label Feb 1, 2024
mertcandav
mertcandav approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@mertcandav mertcandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@mertcandav mertcandav merged commit 2e15ac4 into julelang:master Feb 1, 2024
4 checks passed
@vil02 vil02 deleted the avoid_sign_conversion_in_utf8_to_runes branch February 1, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcandav mertcandav mertcandav approved these changes

Assignees
No one assigned
Labels
api About API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @mertcandav