Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use fixed width integer types to define jule types #73

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Feb 1, 2024

Description

Since the true size of basic integer types might be everything depended, I suggest to define jule integer types using the fixed with integer types.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing tests pass.
  • The code follows the code style and conventions of the project.
  • No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
  • I have read the whole Contributing guidelines of the project and its resources/related pages.

Screenshots (if any)

Note to reviewers

Use fixed width integer types to define jule types.

@mertcandav mertcandav self-requested a review February 1, 2024 21:01
@mertcandav mertcandav added the api About API label Feb 1, 2024
Copy link
Member

@mertcandav mertcandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@mertcandav mertcandav merged commit e5aa529 into julelang:master Feb 1, 2024
4 checks passed
@vil02
Copy link
Contributor Author

vil02 commented Feb 1, 2024

@mertcandav do you know what have happened in this job?

@vil02 vil02 deleted the use_fixed_with_int_types branch February 1, 2024 21:21
@mertcandav
Copy link
Member

Not yet. I will review this problem as far as soon. I will revert this PR and open an issue for that.
If you have idea about that, please share with us via relevant issue.

Thanks.

@mertcandav mertcandav added compiler/runtime Related with runtime compiler Related with compiler/compile-time labels Feb 1, 2024
@vil02
Copy link
Contributor Author

vil02 commented Feb 1, 2024

(since the issue is not yet there)

Did you try to simply rerun the failed jobs? When I synchronized my fork, both build and tests were successful.

@mertcandav
Copy link
Member

No, I'll investigate. There are might be more deep problems.
But issue also discuss some things. Then, I think we can merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api About API compiler/runtime Related with runtime compiler Related with compiler/compile-time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants