Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make array_oop actually test something #84

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Feb 4, 2024

Description

This PR make the test of array to actually check something.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing tests pass.
  • The code follows the code style and conventions of the project.
  • No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
  • I have read the whole Contributing guidelines of the project and its resources/related pages.

Screenshots (if any)

Note to reviewers

Add some asserts to array test.

@mertcandav mertcandav self-requested a review February 4, 2024 11:56
@vil02 vil02 marked this pull request as ready for review February 4, 2024 11:56
Copy link
Member

@mertcandav mertcandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a side note, this tests to check whether compiler can compile actually, not to check whether arrays woks correct.

Thanks for your contribution.

@mertcandav mertcandav merged commit 734d2a9 into julelang:master Feb 4, 2024
8 checks passed
@vil02
Copy link
Contributor Author

vil02 commented Feb 4, 2024

As a side note, this tests to check whether compiler can compile actually, not to check whether arrays woks correct.

In this case I would leave the print statements (together with asserts).

@vil02 vil02 deleted the make_array_opp_test_something branch February 4, 2024 12:07
@vil02 vil02 mentioned this pull request Feb 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants