Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if *this is src in Array::operator== #86

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Feb 4, 2024

Description

Note that, since this->begin() == src.begin() is equivalent to *this == src, because buf is owned by the Array object.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing tests pass.
  • The code follows the code style and conventions of the project.
  • No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
  • I have read the whole Contributing guidelines of the project and its resources/related pages.

Screenshots (if any)

Note to reviewers

Simplify condition in Array::operator==.

@mertcandav mertcandav self-requested a review February 4, 2024 17:22
@mertcandav mertcandav added the api About API label Feb 4, 2024
Copy link
Member

@mertcandav mertcandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@mertcandav mertcandav merged commit 85a6531 into julelang:master Feb 4, 2024
8 checks passed
@vil02 vil02 mentioned this pull request Feb 4, 2024
5 tasks
@vil02 vil02 deleted the operator_eq_in_array_patch branch February 4, 2024 17:54
vil02 added a commit to vil02/jule that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api About API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants