refactor: use `jule::Str::begin()` in `jule::Str::end()` #90

vil02 · 2024-02-08T19:32:17Z

Description

The jule::Str::end() can be expressed using jule::Str::begin().

Checklist

A description of the changes in this PR is mentioned above.
All the new and existing tests pass.
The code follows the code style and conventions of the project.
No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
I have read the whole Contributing guidelines of the project and its resources/related pages.

Screenshots (if any)

Note to reviewers

Use jule::Str::begin() in jule::Str::end().

mertcandav

LGTM. Thanks for your contribution.

refactor: use jule::Str::begin() in jule::Str::end()

85125c2

mertcandav self-requested a review February 8, 2024 19:33

vil02 marked this pull request as ready for review February 8, 2024 19:33

mertcandav approved these changes Feb 8, 2024

View reviewed changes

mertcandav added the api About API (C++ API, not std/runtime API implementation) label Feb 8, 2024

mertcandav merged commit 4da105a into julelang:master Feb 8, 2024
8 checks passed

vil02 deleted the use_begin_in_end_str branch February 8, 2024 19:34

vil02 added a commit to vil02/jule that referenced this pull request Feb 27, 2024

refactor: use jule::Str::begin() in jule::Str::end() (julelang#90)

d22284c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: use `jule::Str::begin()` in `jule::Str::end()` #90

refactor: use `jule::Str::begin()` in `jule::Str::end()` #90

vil02 commented Feb 8, 2024

mertcandav left a comment

refactor: use jule::Str::begin() in jule::Str::end() #90

refactor: use jule::Str::begin() in jule::Str::end() #90

Conversation

vil02 commented Feb 8, 2024

Description

Checklist

Screenshots (if any)

Note to reviewers

mertcandav left a comment

Choose a reason for hiding this comment

refactor: use `jule::Str::begin()` in `jule::Str::end()` #90

refactor: use `jule::Str::begin()` in `jule::Str::end()` #90