Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: use pointer to const #98

Merged
merged 1 commit into from
Feb 27, 2024
Merged

style: use pointer to const #98

merged 1 commit into from
Feb 27, 2024

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Feb 27, 2024

Description

Pointers to consts could be use in these places.

Checklist

  • A description of the changes in this PR is mentioned above.
  • All the new and existing tests pass.
  • The code follows the code style and conventions of the project.
  • No plagiarized, duplicated, or repetitive code that has been directly copied from another source.
  • I have read the whole Contributing guidelines of the project and its resources/related pages.

Screenshots (if any)

Note to reviewers

Use pointer to const.

@vil02 vil02 marked this pull request as ready for review February 27, 2024 20:10
@mertcandav mertcandav self-requested a review February 27, 2024 21:50
@mertcandav mertcandav added the api About API (C++ API, not std/runtime API implementation) label Feb 27, 2024
mertcandav
mertcandav approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@mertcandav mertcandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@mertcandav mertcandav merged commit 866f926 into julelang:master Feb 27, 2024
12 checks passed
@vil02 vil02 deleted the use_ptr_to_const branch February 27, 2024 21:55
@mertcandav
Copy link
Member

I'll revert PR because of compilation problems.

mertcandav added a commit that referenced this pull request Feb 27, 2024
@mertcandav
Revert "style: use pointer to const (#98)"
ccf9c9e 
This reverts commit 866f926.
@mertcandav mertcandav mentioned this pull request Feb 27, 2024
Merged
mertcandav added a commit that referenced this pull request Feb 27, 2024
@mertcandav
Revert "style: use pointer to const (#98)" (#99)
7cc3a3b 
This reverts commit 866f926.
@vil02
Copy link
Contributor Author

vil02 commented Feb 28, 2024

I'll revert PR because of compilation problems.

Sorry for the problems. Do you have some idea how to improve the CI to avoid such situations in the future?

@mertcandav
Copy link
Member

Current CI processes may need some modification, I'll take a look at that.
I think I can reach to the necessary CI responsiveness.

@mertcandav
Copy link
Member

I opened an issue about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcandav mertcandav mertcandav approved these changes

Assignees
No one assigned
Labels
api About API (C++ API, not std/runtime API implementation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @mertcandav