Skip to content

Commit

Permalink
Make embed instruction default to empty string
Browse files Browse the repository at this point in the history
  • Loading branch information
HamadaSalhab committed Oct 22, 2024
1 parent 014c5cb commit 1e22e30
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion agents-api/agents_api/autogen/Docs.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class EmbedQueryRequest(BaseModel):
"""
Text or texts to embed
"""
embed_instruction: str | None = None
embed_instruction: str = ""
"""
Instruction for the embedding model.
"""
Expand Down
2 changes: 1 addition & 1 deletion typespec/docs/models.tsp
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ model EmbedQueryRequest {
text: string | string[];

/** Instruction for the embedding model. */
embed_instruction: string | null = null;
embed_instruction: string = "";
}

model EmbedQueryResponse {
Expand Down
3 changes: 1 addition & 2 deletions typespec/tsp-output/@typespec/openapi3/openapi-0.4.0.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2588,9 +2588,8 @@ components:
description: Text or texts to embed
embed_instruction:
type: string
nullable: true
description: Instruction for the embedding model.
default: null
default: ''
Docs.EmbedQueryResponse:
type: object
required:
Expand Down
3 changes: 1 addition & 2 deletions typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2588,9 +2588,8 @@ components:
description: Text or texts to embed
embed_instruction:
type: string
nullable: true
description: Instruction for the embedding model.
default: null
default: ''
Docs.EmbedQueryResponse:
type: object
required:
Expand Down

0 comments on commit 1e22e30

Please sign in to comment.