-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove non-relevant tests #1004
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to f282a85 in 9 seconds
More details
- Looked at
46
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. agents-api/tests/test_activities.py:12
- Draft comment:
Consider using a descriptive name for the test function instead of an underscore to improve readability and maintainability. - Reason this comment was not posted:
Confidence changes required:50%
The test function is using an underscore as its name, which is not descriptive. This can make it difficult to understand the purpose of the test at a glance.
Workflow ID: wflow_irHW0tsr4tQ6BXMv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
CI Failure Feedback 🧐(Checks updated until commit f282a85)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
PR Type
Tests
Description
Removed non-relevant test cases from
test_activities.py
.Cleaned up unused imports and commented-out code.
Changes walkthrough 📝
test_activities.py
Removed non-relevant tests and unused imports
agents-api/tests/test_activities.py
Important
Remove non-relevant commented-out tests from
test_activities.py
, retaining demo workflow test.embed_docs
intest_activities.py
.test_activities.py
.This description was created by for f282a85. It will automatically update as commits are pushed.