fix(agents-api): Fix test_workflow_routes suite

[HamadaSalhab]

PR Type

Bug fix, Tests

---

Description

• Fixed temporal connection issue in test_task_routes.

• Updated test_workflow_routes to use patch_testing_temporal.

• Removed unused imports and redundant database pool creation.

• Improved comments for clarity in test cases.

---

Changes walkthrough 📝

	Relevant files
Bug fix	test_task_routes.py Fix and clarify temporal connection issue in tests              agents-api/tests/test_task_routes.py Updated skip reason for temporal connection issue. Added a clarifying comment for the failing test. +4/-1
Tests	test_workflow_routes.py Refactor workflow route tests for simplicity                          agents-api/tests/test_workflow_routes.py Replaced patch_http_client_with_temporal with patch_testing_temporal. Removed unused imports and database pool creation. Simplified test setup for workflow routes. +8/-30

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

---

Important

Simplify test_workflow_routes setup and clarify temporal connection issue in test_task_routes.py.

• Tests:
  • In test_workflow_routes.py, remove create_db_pool and developer_id from tests, simplifying setup.
  • Replace patch_http_client_with_temporal with patch_testing_temporal in test_workflow_routes.py for consistency.
  • Update comment in test_task_routes.py to clarify temporal connection issue.

^{This description was created by for 37f23df. It will automatically update as commits are pushed.}

[qodo-merge-pro-for-open-source]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Test Coverage The removal of database pool creation and developer_id might affect test isolation. Verify that patch_testing_temporal properly handles all necessary test dependencies. async with patch_testing_temporal(): task_data = { "name": "test task", "description": "test task about", "input_schema": {"type": "object", "additionalProperties": True},

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 37f23df in 12 seconds

More details

• Looked at 100 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. agents-api/tests/test_workflow_routes.py:6

• Draft comment:
  The import test_developer_id is removed, but it's not used in this file. Ensure that this change aligns with the intent to clean up unused imports.
• Reason this comment was not posted:
  Comment did not seem useful.

2. agents-api/tests/test_task_routes.py:244

• Draft comment:
  Fixes a typo in the comment. Ensure that this aligns with the intent to improve code quality.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The PR description does not mention changes to test_task_routes.py, but the diff includes a fix for a typo in a comment. This is a minor change and aligns with the intent to improve code quality.

Workflow ID: wflow_4XVGI6IcQ8UPuJXJ

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[qodo-merge-pro-for-open-source]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add validation to ensure test environment dependencies are properly initialized Add error handling and assertions after the patch_testing_temporal() context manager to verify the temporal connection was successful and the test environment is properly set up. agents-api/tests/test_workflow_routes.py [18-22] -async with patch_testing_temporal(): +async with patch_testing_temporal() as temporal_client: + assert temporal_client is not None, "Temporal client initialization failed" task_data = { "name": "test task", "description": "test task about", "input_schema": {"type": "object", "additionalProperties": True}, Apply this suggestion Suggestion importance[1-10]: 7 Why: Adding validation for the temporal client initialization would help catch setup issues early and make test failures more debuggable. This is particularly relevant given the temporal connection issues mentioned elsewhere in the PR.	7
General	Improve clarity and professionalism of test documentation comments Fix the typo in the skip reason comment to maintain code clarity and documentation accuracy. agents-api/tests/test_task_routes.py [244-246] -# It's failing while getting the temporal client in -# the `update_execution.py` route, but it's correctly -# getting it in the `create_task_execution.py` route +# Test is skipped: Temporal client initialization fails in +# `update_execution.py` route, while succeeding in +# `create_task_execution.py` route Apply this suggestion Suggestion importance[1-10]: 3 Why: While the suggested comment rephrasing is clearer, it's a minor improvement that only affects readability without impacting functionality. The existing comment is already informative enough.	3