Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: litellm upstream version #1025

Merged
merged 1 commit into from
Jan 6, 2025
Merged

chore: litellm upstream version #1025

merged 1 commit into from
Jan 6, 2025

Conversation

Vedantsahai18
Copy link
Member

@Vedantsahai18 Vedantsahai18 commented Jan 6, 2025

PR Type

enhancement


Description

  • Updated the Docker image reference in docker-compose.yml.

  • Changed the image source to ghcr.io/berriai with version main-v1.57.0.


Changes walkthrough 📝

Relevant files
Configuration changes
docker-compose.yml
Update Docker image reference and source                                 

llm-proxy/docker-compose.yml

  • Updated the Docker image reference.
  • Commented out the old image reference.
  • Changed the image source to ghcr.io/berriai with version main-v1.57.0.
  • +2/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information


    Important

    Update litellm-base image in docker-compose.yml to ghcr.io/berriai/litellm-database:main-v1.57.0.

    • Docker Image Update:
      • In docker-compose.yml, update litellm-base image from julepai/litellm-database:fix_anthropic_tool_image_content-amd64 to ghcr.io/berriai/litellm-database:main-v1.57.0.

    This description was created by Ellipsis for 8083b85. It will automatically update as commits are pushed.

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    @ellipsis-dev ellipsis-dev bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    👍 Looks good to me! Reviewed everything up to 8083b85 in 9 seconds

    More details
    • Looked at 14 lines of code in 1 files
    • Skipped 0 files when reviewing.
    • Skipped posting 1 drafted comments based on config settings.
    1. llm-proxy/docker-compose.yml:5
    • Draft comment:
      Ensure that the new image ghcr.io/berriai/litellm-database:main-v1.57.0 is compatible with the existing configuration and services. Test thoroughly to confirm no breaking changes.
    • Reason this comment was not posted:
      Confidence changes required: 50%
      The PR changes the image source for the litellm-database service. This is a straightforward change, but it's important to ensure that the new image is compatible with the existing setup.

    Workflow ID: wflow_HbcU48fYTkyb8oDI


    You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

    @Vedantsahai18 Vedantsahai18 linked an issue Jan 6, 2025 that may be closed by this pull request
    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Use immutable image references by pinning to SHA hash instead of mutable version tags

    Pin the Docker image to a specific SHA hash instead of using a version tag to ensure
    immutable and reproducible builds.

    llm-proxy/docker-compose.yml [5]

    -image: ghcr.io/berriai/litellm-database:main-v1.57.0
    +image: ghcr.io/berriai/litellm-database@sha256:<specific-sha256-hash>
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Using SHA hash pinning for Docker images is a critical security and reliability best practice, as it prevents supply chain attacks and ensures reproducible builds by avoiding mutable tags that can point to different images over time.

    8

    Copy link
    Contributor

    @standard-input standard-input bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    No issues flagged.
    Standard Input can make mistakes. Check important info.
    

    @Vedantsahai18 Vedantsahai18 merged commit a3edb51 into dev Jan 6, 2025
    6 checks passed
    @Vedantsahai18 Vedantsahai18 deleted the x/litellm branch January 6, 2025 18:19
    @Vedantsahai18 Vedantsahai18 linked an issue Jan 6, 2025 that may be closed by this pull request
    1 task
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    [Refactor]: Switch back to original litellm package [Bug]: The custom litellm package is not being installed
    1 participant