F/bb sdk v1.0: Updating the BrowserBase SDK from v0.x to v1.x #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 14144715 | Triggered | Generic Password | 253c732 | deploy/simple-docker-compose.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
1 task
CI Failure Feedback 🧐(Checks updated until commit 9f7c363)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to b033fb4 in 1 minute and 2 seconds
More details
- Looked at
365lines of code in4files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. integrations-service/uv.lock:229
- Draft comment:
Use 'sys_platform' instead of 'platform_system' for consistency.
{ name = "colorama", marker = "sys_platform == 'win32'" },
- Reason this comment was not posted:
Confidence changes required:50%
The code is using 'platform_system' instead of 'sys_platform' in the marker for 'colorama'. This should be consistent with the other changes in the lock file.
Workflow ID: wflow_H77qeuBHPO1bmrlC
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
integrations-service/integrations/utils/integrations/browserbase.py
Outdated
Show resolved
Hide resolved
…se.py Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
![qodo-merge-pro-for-open-source[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 4498579 in 30 seconds
More details
- Looked at
484lines of code in9files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. integrations-service/integrations/models/browserbase.py:16
- Draft comment:
The field nameconnectionUrlshould be consistently updated toconnect_urlto follow Python naming conventions. This change should be reflected wherever this field is used. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_alMqZVg7DjRgnzuP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 666f5a6 in 15 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/docker-compose.yml:54
- Draft comment:
Consider verifying if specifying the platform is necessary for all services or just specific ones. This can help avoid unnecessary constraints. - Reason this comment was not posted:
Confidence changes required:50%
The addition of the 'platforms' key in the docker-compose.yml file is a good practice for ensuring compatibility with specific architectures. However, it should be verified if this is necessary for all services or just specific ones.
Workflow ID: wflow_KRuBLXkufgEkaUIv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
Skipped PR review on de652e3 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Bug fix
Description
Updated the BrowserBase SDK integration to v1.0.
Refactored session handling methods for improved clarity.
Enhanced error handling in session and extension operations.
Updated dependencies to use the latest BrowserBase SDK version.
Changes walkthrough 📝
browserbase.py
Update models to align with BrowserBase SDK v1.0integrations-service/integrations/models/browserbase.py
connectionUrlfield toBrowserbaseCreateSessionOutput.DebugConnectionURLswithSessionLiveURLs.browserbase.py
Refactor and enhance BrowserBase integration utilitiesintegrations-service/integrations/utils/integrations/browserbase.py
pyproject.toml
Update BrowserBase SDK dependency versionintegrations-service/pyproject.toml
browserbasedependency to version>=1.0.5.Important
Update BrowserBase SDK to v1.0, refactor session handling, and remove deprecated connection URL methods.
pyproject.toml.BrowserbaseGetSessionConnectUrlArgumentsand related classes inTools.pyandbrowserbase.py.browserbase.py.platformstodocker-compose.ymlforlinux/amd64.connectionUrlfield inBrowserbaseCreateSessionOutputandBrowserbaseGetSessionOutput.This description was created by
for 666f5a6. It will automatically update as commits are pushed.