Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(memory-store): fix vector search function #1046

Merged
merged 3 commits into from
Jan 13, 2025
Merged

fix(memory-store): fix vector search function #1046

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c9e5ee
fix(memory-store): fix vector search function
Ahmad-mtos Jan 13, 2025
aff6bd4
fix: set order direction explicitly
Ahmad-mtos Jan 13, 2025
c9e9e87
fix(agents-api): adjuct ``confidence`` range
Ahmad-mtos Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions memory-store/migrations/000022_vector_search.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ CREATE OR REPLACE FUNCTION search_by_vector (
owner_types TEXT[],
owner_ids UUID [],
k integer DEFAULT 3,
confidence float DEFAULT 0.5,
confidence float DEFAULT 0.0,
metadata_filter jsonb DEFAULT NULL
) RETURNS SETOF doc_search_result LANGUAGE plpgsql AS $$
DECLARE
Expand All @@ -19,8 +19,8 @@ BEGIN
RAISE EXCEPTION 'k must be greater than 0';
END IF;

IF confidence < 0 OR confidence > 1 THEN
RAISE EXCEPTION 'confidence must be between 0 and 1';
IF confidence < -1 OR confidence > 1 THEN
RAISE EXCEPTION 'confidence must be between -1 and 1';
END IF;

IF owner_types IS NOT NULL AND owner_ids IS NOT NULL AND
Expand All @@ -29,7 +29,7 @@ BEGIN
END IF;

-- Calculate search threshold from confidence
search_threshold := confidence;
search_threshold := 1.0 - confidence;

-- Build owner filter SQL
owner_filter_sql := '
Expand All @@ -53,23 +53,23 @@ BEGIN
d.index,
d.title,
d.content,
((1 - (d.embedding <=> $1)) + 1) * 0.5 as distance,
(d.embedding <=> $1) as distance,
d.embedding,
d.metadata,
doc_owners.owner_type,
doc_owners.owner_id
FROM docs_embeddings d
LEFT JOIN doc_owners ON d.doc_id = doc_owners.doc_id
WHERE d.developer_id = $7
AND ((1 - (d.embedding <=> $1)) + 1) * 0.5 >= $2
AND (d.embedding <=> $1) <= $2
%s
%s
ORDER BY ((1 - (d.embedding <=> $1)) + 1) * 0.5 DESC
ORDER BY (d.embedding <=> $1) ASC
LIMIT ($3 * 4) -- Get more candidates than needed
)
SELECT DISTINCT ON (doc_id) *
FROM ranked_docs
ORDER BY doc_id, distance DESC
ORDER BY doc_id, distance ASC
LIMIT $3',
owner_filter_sql,
metadata_filter_sql
Expand Down
Loading