-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): Improve cli wrapper and fix init command behavior #1214
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
WalkthroughThis PR enhances the NLP module by refining keyword extraction functions and introducing a new parameter for improved full-text search capabilities. The CLI has been refactored for better modularity, including new utility functions, a custom prompt style, and template selection support in the Changes
Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
|
keywords = extract_keywords(sent_doc, top_n, split_chunks=split_chunks) | ||
keywords = [kw for kw in keywords if len(kw) > 1] | ||
if len(keywords) < min_keywords: | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filtering keywords with len(kw) > 1
after extraction could return fewer keywords than min_keywords
, making the minimum check ineffective. Move length check before the minimum check.
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
keywords = extract_keywords(sent_doc, top_n, split_chunks=split_chunks) | |
keywords = [kw for kw in keywords if len(kw) > 1] | |
if len(keywords) < min_keywords: | |
continue | |
keywords = [kw for kw in extract_keywords(sent_doc, top_n, split_chunks=split_chunks) if len(kw) > 1] | |
if len(keywords) < min_keywords: | |
continue |
EntelligenceAI PR Summary
Purpose:
Changes:
init
command.Impact: