Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add linting github action #185

Merged
merged 1 commit into from
Apr 15, 2024
Merged

chore: Add linting github action #185

merged 1 commit into from
Apr 15, 2024

Conversation

whiterabbit1983
Copy link
Contributor

@whiterabbit1983 whiterabbit1983 commented Apr 15, 2024

Ellipsis 🚀 This PR description was created by Ellipsis for commit f3a74e6.

Summary:

This PR adds a new GitHub action that lints and formats the Agents API, Models API, and Python SDK on every push and pull request, using poetry for Python dependency management and task running.

Key points:

  • New GitHub action added in .github/workflows/lint-and-format.yml
  • Action is triggered on every push and pull request
  • Lints and formats Agents API, Models API, and Python SDK
  • Uses poetry for Python dependency management and task running

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested.

  • Reviewed the entire pull request up to 1417024
  • Looked at 22 lines of code in 1 files
  • Took 1 minute and 45 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.
1. .github/workflows/lint-and-format.yml:14:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    The name of this step might be misleading as it suggests that it's only responsible for linting and formatting, not running tests. Consider renaming it to reflect that it also runs tests.
- name: Lint, format and test NodeJS SDK
  • Reasoning:
    The last step in the workflow is running tests for the NodeJS SDK, but the name of the step is 'Lint and format NodeJS SDK'. This could be misleading as it suggests that the step is only responsible for linting and formatting, not running tests.

Workflow ID: wflow_iuzzWZ35ql8LmKdv


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.

.github/workflows/lint-and-format.yml Outdated Show resolved Hide resolved
.github/workflows/lint-and-format.yml Show resolved Hide resolved
@whiterabbit1983 whiterabbit1983 force-pushed the f/linting-github-action branch from 1417024 to 406210d Compare April 15, 2024 07:33
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested.

  • Performed an incremental review on 406210d
  • Looked at 22 lines of code in 1 files
  • Took 2 minutes and 13 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 0 additional comments because they didn't meet confidence threshold of 50%.

Workflow ID: wflow_C6Dbs2NVelcfFvkk


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.

.github/workflows/lint-and-format.yml Outdated Show resolved Hide resolved
@whiterabbit1983 whiterabbit1983 force-pushed the f/linting-github-action branch from 406210d to 837bfa9 Compare April 15, 2024 07:39
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested.

  • Performed an incremental review on 837bfa9
  • Looked at 27 lines of code in 1 files
  • Took 2 minutes and 39 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 0 additional comments because they didn't meet confidence threshold of 50%.

Workflow ID: wflow_zHSRC1WNXElSQPpK


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.

.github/workflows/lint-and-format.yml Outdated Show resolved Hide resolved
.github/workflows/lint-and-format.yml Show resolved Hide resolved
.github/workflows/lint-and-format.yml Show resolved Hide resolved
@whiterabbit1983 whiterabbit1983 force-pushed the f/linting-github-action branch from 837bfa9 to f3a74e6 Compare April 15, 2024 08:01
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested.

  • Performed an incremental review on f3a74e6
  • Looked at 25 lines of code in 1 files
  • Took 1 minute and 53 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 0 additional comments because they didn't meet confidence threshold of 50%.

Workflow ID: wflow_DRrBpHbTqlCklmAi


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.

.github/workflows/lint-and-format.yml Show resolved Hide resolved
@creatorrr creatorrr merged commit f2d865a into dev Apr 15, 2024
3 checks passed
@creatorrr creatorrr deleted the f/linting-github-action branch April 15, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants