-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add linting github action #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested.
- Reviewed the entire pull request up to 1417024
- Looked at
22
lines of code in1
files - Took 1 minute and 45 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
1
additional comments because they didn't meet confidence threshold of50%
.
1. .github/workflows/lint-and-format.yml:14
:
- Assessed confidence :
100%
- Grade:
0%
- Comment:
The name of this step might be misleading as it suggests that it's only responsible for linting and formatting, not running tests. Consider renaming it to reflect that it also runs tests.
- name: Lint, format and test NodeJS SDK
- Reasoning:
The last step in the workflow is running tests for the NodeJS SDK, but the name of the step is 'Lint and format NodeJS SDK'. This could be misleading as it suggests that the step is only responsible for linting and formatting, not running tests.
Workflow ID: wflow_iuzzWZ35ql8LmKdv
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. We'll respond in a few minutes. Learn more here.
1417024
to
406210d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested.
- Performed an incremental review on 406210d
- Looked at
22
lines of code in1
files - Took 2 minutes and 13 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
0
additional comments because they didn't meet confidence threshold of50%
.
Workflow ID: wflow_C6Dbs2NVelcfFvkk
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. We'll respond in a few minutes. Learn more here.
406210d
to
837bfa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested.
- Performed an incremental review on 837bfa9
- Looked at
27
lines of code in1
files - Took 2 minutes and 39 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
0
additional comments because they didn't meet confidence threshold of50%
.
Workflow ID: wflow_zHSRC1WNXElSQPpK
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. We'll respond in a few minutes. Learn more here.
837bfa9
to
f3a74e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested.
- Performed an incremental review on f3a74e6
- Looked at
25
lines of code in1
files - Took 1 minute and 53 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
0
additional comments because they didn't meet confidence threshold of50%
.
Workflow ID: wflow_DRrBpHbTqlCklmAi
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. We'll respond in a few minutes. Learn more here.
Summary:
This PR adds a new GitHub action that lints and formats the Agents API, Models API, and Python SDK on every push and pull request, using
poetry
for Python dependency management and task running.Key points:
.github/workflows/lint-and-format.yml
poetry
for Python dependency management and task runningGenerated with ❤️ by ellipsis.dev