Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use VALID_MODELS to support JULEP_MODELS #308

Merged
merged 1 commit into from
May 2, 2024
+1 −1
Merged

use VALID_MODELS to support JULEP_MODELS #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agents-api/agents_api/model_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def validate_configuration(model: str):
"""
if model not in ALL_AVAILABLE_MODELS:
raise AgentModelNotValid(model, ALL_AVAILABLE_MODELS)
elif model not in get_valid_models():
elif model not in VALID_MODELS:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing get_valid_models() with VALID_MODELS might introduce issues if VALID_MODELS does not dynamically update as get_valid_models() might. This could lead to using outdated or incorrect model validations. Consider reverting this change or ensuring VALID_MODELS updates dynamically as needed.

raise MissingAgentModelAPIKeyError(model)


Expand Down
Loading