Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agents-api): Hybrid docs search #444

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Aug 4, 2024

Signed-off-by: Diwank Tomer [email protected]


🚀 This description was created by Ellipsis for commit 5c75b8f

Summary:

Introduced hybrid document search combining text and embedding-based methods with new and refactored functions.

Key points:

  • Added search_docs_by_text in agents-api/agents_api/models/docs/search_docs_by_text.py for text-based document search.
  • Renamed search_docs.py to search_docs_by_embedding.py and added embedding_size parameter.
  • Introduced search_docs_hybrid in agents-api/agents_api/models/docs/search_docs_hybrid.py to combine text and embedding search results using weighted reciprocal-rank fusion.
  • Updated prepare_chat_context in agents-api/agents_api/models/session/prepare_chat_context.py to remove unused document search parameters.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to fb43eb6 in 28 seconds

More details
  • Looked at 366 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/models/docs/search_docs_by_text.py:1
  • Draft comment:
    The module description incorrectly states it is for searching documents based on embedding queries. It should correctly reflect that it is for text-based searches.
"""This module contains functions for searching documents in the CozoDB based on text queries."""
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_8ALCTsuDZHe7dIIq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 5c75b8f in 32 seconds

More details
  • Looked at 365 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/models/docs/search_docs_by_text.py:1
  • Draft comment:
    The module description incorrectly states that it contains functions for searching documents based on embedding queries. This should be corrected to reflect its actual functionality, which is text-based document search.
"""This module contains functions for searching documents in the CozoDB based on text queries."""
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_8exgDMgRzoeLrHzu


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@whiterabbit1983 whiterabbit1983 merged commit 33e86a2 into dev-tasks-disable-routes Aug 5, 2024
2 of 6 checks passed
@whiterabbit1983 whiterabbit1983 deleted the f/hybrid-search branch August 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants