feat(agents-api): Add temporal workflow lookup relation and queries #446
Conversation
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 94e7301 in 1 minute and 8 seconds
More details
- Looked at
1395lines of code in15files - Skipped
2files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. sdks/ts/src/api/services/DefaultService.ts:812
- Draft comment:
The TypeScript SDK does not reflect the new temporal workflow lookup relation and queries mentioned in the PR description. Please ensure that the SDK is updated accordingly to expose the new functionalities. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_UMiivokyDG9bb1IZ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
❌ Changes requested. Incremental review on f38458e in 49 seconds
More details
- Looked at
77lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_MqeTvPCPdwX73l59
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
|
||
| """ | ||
|
|
||
| get_query += filter |
There was a problem hiding this comment.
The variable filter is used here but it is not defined anywhere in this file. This will cause a NameError at runtime.
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 24418f9 in 50 seconds
More details
- Looked at
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/models/execution/get_paused_execution_token.py:61
- Draft comment:
The removal ofget_query += filtermight have altered the intended query logic. Ensure that all necessary conditions are included in theget_querystring to maintain correct functionality. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_EQmhmh9p96UeVjKn
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
whiterabbit1983
merged commit 41e5df8
into
dev-tasks-disable-routes
Summary:
Added temporal workflow lookup relation and queries, fixed execution endpoints, and updated models and functions in agents-api.
Key points:
agents-api/agents_api/models/execution/create_execution.py.get_temporal_workflow_datafunction inagents-api/agents_api/models/execution/get_temporal_workflow_data.py.get_paused_execution_tokenfunction inagents-api/agents_api/models/execution/get_paused_execution_token.pyto handle paused execution tokens.agents-api/agents_api/autogen/Executions.py.ExecutionsRouteandPublicEndpointsintypespec/executions/endpoints.tsp.TaskTokenResumeExecutionRequestmodel intypespec/executions/models.tsp.executions_route_resume_with_task_tokenandexecutions_route_updatefunctions insdks/python/julep/api/client.py.Executions_TaskTokenResumeExecutionRequestmodel insdks/ts/src/api/models/Executions_TaskTokenResumeExecutionRequest.ts.executionsRouteResumeWithTaskTokenandexecutionsRouteUpdatefunctions insdks/ts/src/api/services/DefaultService.ts.migrations/migrate_1722875101_add_temporal_mapping.py.Generated with ❤️ by ellipsis.dev