-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agents-api): Fix chat endpoint behavior #455
Conversation
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on b4d96dc in 47 seconds
More details
- Looked at
549
lines of code in8
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. agents-api/agents_api/routers/sessions/chat.py:118
- Draft comment:
The handling of therecall
parameter inget_messages
seems incomplete. There's no integration of the fetched documents (doc_references
) into the chat flow or response which might be necessary based on the PR description. Consider implementing or clarifying how these documents affect the chat outcomes.
# Integrate doc_references into the chat flow or clarify their usage
- Reason this comment was not posted:
Confidence of 20% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_2pNqyYbeV0VPgFel
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
b4d96dc
to
c5f3cec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on c5f3cec in 32 seconds
More details
- Looked at
549
lines of code in8
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. agents-api/agents_api/routers/sessions/chat.py:124
- Draft comment:
The PR description suggests changes to chat endpoint behavior, but the actual implementation contains placeholders likeraise NotImplementedError("Truncation is not yet implemented")
. If these features are not yet ready, it might be better to update the PR description to reflect the current state of the implementation to avoid confusion. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_rMaT5JPnqFBtdPQ7
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
c5f3cec
to
31e0728
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 31e0728 in 44 seconds
More details
- Looked at
680
lines of code in12
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. agents-api/agents_api/worker/__main__.py:11
- Draft comment:
The PR description mentions the removal ofdemo.py
, but it is not shown in the PR diff. Please ensure that all intended deletions are included in the PR. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_ci00HGJGgszbw1gE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on dbb1b32 in 40 seconds
More details
- Looked at
1292
lines of code in20
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. agents-api/agents_api/activities/embed_docs.py:18
- Draft comment:
Consider removing the default value forinclude_title
in theembed_docs
function to enforce explicit behavior control by the caller.
include_title: bool,
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_8l3P9CiR4hOVzUfm
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
1e99713
into
dev-tasks-disable-routes
Summary:
This PR fixes chat endpoint behavior, updates type checks, refactors client usage, changes the default model, and enhances tests in
agents-api
.Key points:
agents-api
andagents-api/routers/sessions/chat.py
.agents-api/activities/types.py
.agents-api/activities/task_steps/__init__.py
.gpt-4o
.demo.py
,dialog_insights
,relationship_summary
, andsalient_questions
activities and workflows.julep_client
withlitellm
.ChatInput
andCompetionUsage
types.agents-api/routers/sessions/chat.py
.chat
function to handlerecall
parameter.pytype.toml
and add tests for non-recall chat messages.Generated with ❤️ by ellipsis.dev