Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Build cozo-bin docker image directly from cozo repo #469

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Aug 26, 2024

🚀 This description was created by Ellipsis for commit d2eeb3f

Summary:

The PR updates memory-store/Dockerfile to build the cozo-bin directly from the CozoDB repository using a multi-stage Docker build process.

Key points:

  • Modify memory-store/Dockerfile to build cozo-bin from CozoDB repo.
  • Use multi-stage Docker build: first stage compiles cozo-bin using Rust.
  • Clone CozoDB repo at specific commit 57b7b440fd93440d985f2259eeaaf2ba5cc7569e.
  • Install liburing-dev for building.
  • Copy compiled binary to /usr/local/bin/cozo.
  • Second stage creates final image with dependencies and compiled binary.
  • Remove memory-store/bin/cozo-bin file.

Generated with ❤️ by ellipsis.dev

@creatorrr creatorrr merged commit d2ea81a into dev-tasks Aug 26, 2024
1 of 5 checks passed
@creatorrr creatorrr deleted the x/upgrade-cozo-docker-image branch August 26, 2024 19:58
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d2eeb3f in 16 seconds

More details
  • Looked at 80 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. memory-store/Dockerfile:7
  • Draft comment:
    Consider adding a SHELL ["/bin/bash", "-c"] command to specify the shell to use, ensuring compatibility with script syntax.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The Dockerfile is missing a SHELL command to specify the shell to use. This can lead to issues if the default shell is not compatible with the script syntax.
2. memory-store/Dockerfile:10
  • Draft comment:
    Consider using apt-get install --no-install-recommends to avoid installing unnecessary packages and reduce the image size. This is applicable to other apt-get install commands as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The Dockerfile uses apt-get install without specifying --no-install-recommends, which can lead to a larger image size due to unnecessary packages being installed.
3. memory-store/Dockerfile:35
  • Draft comment:
    Consider using apt-get install --no-install-recommends to avoid installing unnecessary packages and reduce the image size. This is applicable to other apt-get install commands as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The Dockerfile uses apt-get install without specifying --no-install-recommends, which can lead to a larger image size due to unnecessary packages being installed.

Workflow ID: wflow_rJxjitZa5l0v8pUV


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant