-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add API call tool type #571
Conversation
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 5339101 in 16 seconds
More details
- Looked at
449
lines of code in7
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_gK1AaqWhyGYCAm8B
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
…elation Signed-off-by: Diwank Singh Tomer <[email protected]>
|
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to c24e57a in 46 seconds
More details
- Looked at
939
lines of code in18
files - Skipped
0
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. agents-api/agents_api/activities/task_steps/base_evaluate.py:56
- Draft comment:
Support for nested dictionaries inbase_evaluate
is a significant change. Ensure that this does not break existing functionality. - Reason this comment was not posted:
Confidence changes required:50%
Thebase_evaluate
function has been updated to handle nested dictionaries. This change should be noted for its potential impact on existing functionality.
2. agents-api/agents_api/autogen/Tasks.py:947
- Draft comment:
Support for nested dictionaries inToolCallStep.arguments
is a significant change. Ensure that this does not break existing functionality. - Reason this comment was not posted:
Confidence changes required:50%
TheToolCallStep
class has been updated to support nested dictionaries in thearguments
field. This change should be noted for its potential impact on existing functionality.
3. agents-api/agents_api/autogen/Tools.py:151
- Draft comment:
The addition of adescription
field inApiCallDef
is a significant change. Ensure that this does not break existing functionality. - Reason this comment was not posted:
Confidence changes required:50%
TheApiCallDef
class inTools.py
has been updated to include adescription
field. This change should be noted for its potential impact on existing functionality.
4. agents-api/agents_api/models/tools/create_tools.py:68
- Draft comment:
The addition of adescription
field in tool records is a significant change. Ensure that this does not break existing functionality. - Reason this comment was not posted:
Confidence changes required:50%
Thecreate_tools
function increate_tools.py
has been updated to include adescription
field in the tool records. This change should be noted for its potential impact on existing functionality.
5. agents-api/agents_api/models/tools/list_tools.py:36
- Draft comment:
The addition of adescription
field in tool records is a significant change. Ensure that this does not break existing functionality. - Reason this comment was not posted:
Confidence changes required:50%
Thelist_tools
function inlist_tools.py
has been updated to include adescription
field in the tool records. This change should be noted for its potential impact on existing functionality.
Workflow ID: wflow_ehEvLpWPZcyPbns2
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 3fe372e in 15 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. agents-api/tests/test_docs_queries.py:43
- Draft comment:
The TODO comment is vague. Consider providing more specific guidance or linking to an issue tracker for better clarity on how to resolve the test issue. - Reason this comment was not posted:
Confidence changes required:50%
The TODO comment suggests a known issue with the test, but it doesn't provide a clear path to resolution. This can be improved by providing more specific guidance or linking to an issue tracker.
Workflow ID: wflow_pIbmmkeU6lkGgPHQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
…ders back Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 326067a in 15 seconds
More details
- Looked at
32
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. agents-api/agents_api/activities/excecute_api_call.py:28
- Draft comment:
CatchingBaseException
is too broad and can lead to unintended behavior. Consider catching more specific exceptions likehttpx.HTTPStatusError
orException
. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_qfgRWqiuaxvHzgx6
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add API call tool type and description field to agent tools, updating models and types accordingly.
ApiCallDef
andApiCallDefUpdate
classes inTools.py
to define API call tools.api_call
field toCreateToolRequest
,PatchToolRequest
,UpdateToolRequest
, andTool
classes inTools.py
.description
field toCreateToolRequest
,PatchToolRequest
,UpdateToolRequest
, andTool
classes inTools.py
.prepare_chat_context.py
andprepare_execution_input.py
to includedescription
in tool data.execute_api_call()
inexcecute_api_call.py
to handle API call execution.httpMethod
alias inscalars.tsp
for valid HTTP methods.ApiCallDef
model inmodels.tsp
for API call tools.create_tools.py
andlist_tools.py
to handledescription
field in tool records.migrate_1727922523_add_description_to_tools.py
to adddescription
field to tools table.workflow: tool call api_call
intest_execution_workflow.py
to verify API call tool functionality.This description was created by for 326067a. It will automatically update as commits are pushed.