-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typespec,agents-api): Add system tool call types #585
Conversation
Signed-off-by: Diwank Singh Tomer <[email protected]>
b13f0fa
to
5241358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to b13f0fa in 2 minutes and 0 seconds
More details
- Looked at
12952
lines of code in6
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_GaQLAZCRHUeteKcx
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 5241358 in 1 minute and 0 seconds
More details
- Looked at
254
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. agents-api/agents_api/autogen/Tools.py:38
- Draft comment:
Changingdata
fromdict[str, str]
todict[str, Any]
allows for more flexibility but could introduce issues if specific types are expected. Ensure this change is intentional and documented. This applies toApiCallDefUpdate
as well. - Reason this comment was not posted:
Confidence changes required:50%
The change fromdict[str, str]
todict[str, Any]
indata
fields allows for more flexibility but could introduce issues if the data is expected to be a specific type. This change should be carefully considered and documented.
2. agents-api/agents_api/autogen/Tools.py:199
- Draft comment:
Changingdescription
fromstr
toAny
inFunctionDef
might lead to unexpected types being assigned. Ensure this change is intentional and consider adding validation or documentation. - Reason this comment was not posted:
Confidence changes required:50%
The change fromstr
toAny
fordescription
inFunctionDef
might lead to unexpected types being assigned. This should be validated or documented.
3. agents-api/agents_api/autogen/Tools.py:333
- Draft comment:
Ensure that the new fieldsresource
,operation
,resource_id
, andsubresource
inSystemDef
andSystemDefUpdate
are properly validated and documented. - Reason this comment was not posted:
Confidence changes required:50%
The addition of new fields inSystemDef
andSystemDefUpdate
is consistent with the PR description. However, ensure that these fields are properly validated and documented.
4. typespec/.gitignore:8
- Draft comment:
The changes to.gitignore
are appropriate and ensure that only relevant files are tracked. No issues found. - Reason this comment was not posted:
Confidence changes required:0%
The.gitignore
changes are logical, ensuring that only relevant files are tracked. No issues here.
5. typespec/tools/models.tsp:64
- Draft comment:
The addition ofresourceType
,subresourceType
, andoperationType
aliases is consistent with the changes inTools.py
. Ensure these are used consistently across the codebase. - Reason this comment was not posted:
Confidence changes required:0%
The addition of aliases forresourceType
,subresourceType
, andoperationType
inmodels.tsp
is consistent with the changes inTools.py
. Ensure these are used consistently across the codebase.
Workflow ID: wflow_mQQ3bGlchmwqoBTZ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Generated with ❤️ by ellipsis.dev |
Signed-off-by: Diwank Singh Tomer [email protected]
Important
Add system tool call types and update API models and specifications for version 1.0.0.
timeout
field toApiCallDef
andApiCallDefUpdate
inTools.py
.data
type fromdict[str, str]
todict[str, Any]
inApiCallDef
andApiCallDefUpdate
.description
type fromstr
toAny
inFunctionDef
.resource
,operation
,resource_id
, andsubresource
fields toSystemDef
andSystemDefUpdate
.resourceType
,subresourceType
, andoperationType
inmodels.tsp
.SystemDef
model to include new fields inmodels.tsp
.openapi-1.0.0.yaml
.versions.tsp
to include version1.0.0
.This description was created by for 5241358. It will automatically update as commits are pushed.