Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typespec,agents-api): Add system tool call types #585

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Oct 4, 2024

Signed-off-by: Diwank Singh Tomer [email protected]


Important

Add system tool call types and update API models and specifications for version 1.0.0.

  • Behavior:
    • Add timeout field to ApiCallDef and ApiCallDefUpdate in Tools.py.
    • Change data type from dict[str, str] to dict[str, Any] in ApiCallDef and ApiCallDefUpdate.
    • Change description type from str to Any in FunctionDef.
    • Add resource, operation, resource_id, and subresource fields to SystemDef and SystemDefUpdate.
  • Models:
    • Add new aliases resourceType, subresourceType, and operationType in models.tsp.
    • Update SystemDef model to include new fields in models.tsp.
  • API:
    • Add OpenAPI specification for version 1.0.0 in openapi-1.0.0.yaml.
  • Misc:
    • Update versions.tsp to include version 1.0.0.

This description was created by Ellipsis for 5241358. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b13f0fa in 2 minutes and 0 seconds

More details
  • Looked at 12952 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_GaQLAZCRHUeteKcx


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 5241358 in 1 minute and 0 seconds

More details
  • Looked at 254 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. agents-api/agents_api/autogen/Tools.py:38
  • Draft comment:
    Changing data from dict[str, str] to dict[str, Any] allows for more flexibility but could introduce issues if specific types are expected. Ensure this change is intentional and documented. This applies to ApiCallDefUpdate as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from dict[str, str] to dict[str, Any] in data fields allows for more flexibility but could introduce issues if the data is expected to be a specific type. This change should be carefully considered and documented.
2. agents-api/agents_api/autogen/Tools.py:199
  • Draft comment:
    Changing description from str to Any in FunctionDef might lead to unexpected types being assigned. Ensure this change is intentional and consider adding validation or documentation.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from str to Any for description in FunctionDef might lead to unexpected types being assigned. This should be validated or documented.
3. agents-api/agents_api/autogen/Tools.py:333
  • Draft comment:
    Ensure that the new fields resource, operation, resource_id, and subresource in SystemDef and SystemDefUpdate are properly validated and documented.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of new fields in SystemDef and SystemDefUpdate is consistent with the PR description. However, ensure that these fields are properly validated and documented.
4. typespec/.gitignore:8
  • Draft comment:
    The changes to .gitignore are appropriate and ensure that only relevant files are tracked. No issues found.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The .gitignore changes are logical, ensuring that only relevant files are tracked. No issues here.
5. typespec/tools/models.tsp:64
  • Draft comment:
    The addition of resourceType, subresourceType, and operationType aliases is consistent with the changes in Tools.py. Ensure these are used consistently across the codebase.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The addition of aliases for resourceType, subresourceType, and operationType in models.tsp is consistent with the changes in Tools.py. Ensure these are used consistently across the codebase.

Workflow ID: wflow_mQQ3bGlchmwqoBTZ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

ellipsis-dev bot commented Oct 4, 2024

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at [email protected]


Generated with ❤️ by ellipsis.dev

@HamadaSalhab HamadaSalhab merged commit 19c6240 into dev Oct 4, 2024
7 of 9 checks passed
@HamadaSalhab HamadaSalhab deleted the f/system-call-tool branch October 4, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants