Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agents-api): Add doc search system tool #604

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

HamadaSalhab
Copy link
Contributor

@HamadaSalhab HamadaSalhab commented Oct 7, 2024

Important

Adds document creation and search functionalities for agents and users, updates list_docs with a new parameter, and refactors base_evaluate for complex dictionaries.

  • Behavior:
    • Adds support for document creation and search operations in execute_system.py for both agents and users.
    • Introduces create_agent_doc, create_user_doc, search_agent_docs, and search_user_docs functions.
    • Handles text, vector, and hybrid search requests using HybridDocSearchRequest, TextOnlyDocSearchRequest, and VectorDocSearchRequest.
    • Replaces developer_id with x_developer_id for certain operations.
  • Models:
    • Updates list_docs in list_docs.py to include include_without_embeddings parameter.
  • Misc:
    • Refactors base_evaluate in base_evaluate.py to handle nested dictionaries with string values.

This description was created by Ellipsis for 8432e95. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8432e95 in 10 seconds

More details
  • Looked at 206 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. agents-api/agents_api/activities/task_steps/base_evaluate.py:49
  • Draft comment:
    Refactoring to store the result in a variable before returning improves readability. No issues found.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The base_evaluate function in base_evaluate.py has been refactored to store the result in a variable before returning it. This change improves readability and debugging, but it doesn't introduce any functional changes. No issues found here.
2. agents-api/agents_api/models/docs/list_docs.py:74
  • Draft comment:
    The use of include_without_embeddings to conditionally include a filter in the query is well-implemented. No issues found.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    In list_docs.py, the include_without_embeddings parameter is used to conditionally include a filter in the query. This is a good practice for optional filtering, and the implementation seems correct. No issues found.

Workflow ID: wflow_hwLskrBvvIm3VrNn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@HamadaSalhab HamadaSalhab merged commit e36f33b into dev Oct 7, 2024
4 checks passed
@HamadaSalhab HamadaSalhab deleted the f/doc-search-system-tool branch October 7, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants