Ravi praveen patch 2

[RAVI-PRAVEEN]

Summary of Changes:

Granular System Definition: Introduced CreateUserSystemDef as an example of a more specific system call.
Custom Tool Type: Added a custom option to the ToolType enum for future extensibility.
API Call Enhancements: Added fields for retries, rate_limit, page_size, and page_number to ApiCallDef for better error handling and pagination.
Function Parameters: Refined FunctionParameters with more structure and validation (type, required, default).
Tool Logging: Added a log field in the Tool model for logging tool actions (e.g., user, action time).
Improved Comments and Documentation: Added comments to fields for better clarity.

---

Important

Enhances system and tool definitions with new models, error handling, and logging, and updates script for better logging and error handling.

• System and Tool Enhancements:
  • Added CreateUserSystemDef model for specific user creation system calls in models.tsp.
  • Introduced custom option in ToolType enum for future extensibility in models.tsp.
  • Enhanced ApiCallDef with fields for retries, rate_limit, page_size, and page_number for better error handling and pagination in models.tsp.
  • Refined FunctionParameters with structured validation in models.tsp.
  • Added log field in Tool model for logging actions in models.tsp.
• Script Enhancements:
  • Updated generate_openapi_code.sh to include logging with timestamps and error handling.
  • Added options for updating Poetry dependencies and displaying usage information in generate_openapi_code.sh.

^{This description was created by for 9034dd7. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 9034dd7 in 19 seconds

More details

• Looked at 207 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. scripts/generate_openapi_code.sh:7

• Draft comment:
  Redundant 'set -e' as 'set -xe' already includes 'set -e'. Consider removing this line.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The script uses 'set -xe' and 'set -e' which is redundant. 'set -e' is already included in 'set -xe'.

2. scripts/generate_openapi_code.sh:14

• Draft comment:
  Consider removing 'tee' if console output is not needed, as it duplicates the log entry to both the console and the log file.
• Reason this comment was not posted:
  Confidence changes required: 33%
  The 'log_action' function is used to log actions with timestamps, but the 'tee' command is used, which might not be necessary if the output is only needed in the log file.

3. typespec/tools/models.tsp:49

• Draft comment:
  Consider using a more specific type instead of 'Record' for 'ToolOutput' to improve type safety and clarity. This comment also applies to 'data' in 'ApiCallDef'.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The 'FunctionParameters' alias in 'models.tsp' is defined with a specific structure, but the 'Record' type for 'ToolOutput' and 'data' in 'ApiCallDef' is too generic and might benefit from more specific typing.

4. typespec/tools/models.tsp:125

• Draft comment:
  Consider including 'arguments?: FunctionParameters;' in 'CreateUserSystemDef' for consistency with 'SystemDef'.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The 'CreateUserSystemDef' model extends 'SystemDef' but does not include 'arguments', which might be necessary for consistency and functionality.

Workflow ID: wflow_0KSUWYEYwL5ZVcIL

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[creatorrr]

Hi @RAVI-PRAVEEN ,

- We are not accepting changes to typespec models unless absolutely necessary.
- Have you verified if the bash script works correctly? Please post output here that it does and I'd be happy to merge this pr

Closing as duplicate of #615