-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes #627
Merged
Merged
Misc fixes #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 2b78559 in 45 seconds
More details
- Looked at
588
lines of code in9
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. agents-api/agents_api/common/exceptions/tasks.py:23
- Draft comment:
The change from list to tuple forNON_RETRYABLE_ERROR_TYPES
is appropriate as it is used inisinstance
, which requires a tuple. This change is correct and improves the code. - Reason this comment was not posted:
Confidence changes required:0%
The change from list to tuple forNON_RETRYABLE_ERROR_TYPES
is appropriate as it is used inisinstance
, which requires a tuple. This change is correct and improves the code.
2. agents-api/agents_api/models/execution/create_execution_transition.py:179
- Draft comment:
The query construction logic here is complex and could benefit from additional comments or refactoring for improved readability and maintainability. - Reason this comment was not posted:
Confidence changes required:50%
Thecreate_execution_transition
function has a complex query construction logic. It would be beneficial to add comments or refactor the code to improve readability and maintainability.
Workflow ID: wflow_nRTiFjpd8JCPjsg0
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
HamadaSalhab
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR enhances API call execution, extends the standard library, improves error handling, refines execution transitions, and updates workflow execution in the
agents-api
module.execute_api_call
inexcecute_api_call.py
now supports overridingurl
andheaders
viaRequestArgs
.utils.py
extended with classes forre
,json
,yaml
,time
,random
,itertools
,functools
,base64
,urllib
,string
,zoneinfo
,datetime
,math
, andstatistics
.is_non_retryable_error
inexceptions/tasks.py
to acceptBaseException
.CustomActivityInterceptor
andCustomWorkflowInterceptor
ininterceptors.py
now handleBaseException
.create_execution_transition.py
whereexecution.output
was not set correctly for non-error transitions.TaskExecutionWorkflow
intask_execution/__init__.py
.continue_as_child
inhelpers.py
to handle user state via workflow memo.test_execution_workflow.py
to cover new functionalities and ensure correct behavior.This description was created by for 2b78559. It will automatically update as commits are pushed.