Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use ruamel.yaml instead of pyyaml #651

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: Use ruamel.yaml instead of pyyaml #651

merged 1 commit into from
Oct 15, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Oct 15, 2024

Signed-off-by: Diwank Singh Tomer [email protected]


Important

Replace pyyaml with ruamel.yaml for YAML processing and perform minor code cleanups.

  • YAML Processing:
    • Replace pyyaml with ruamel.yaml in utils.py, template.py, and routers/tasks/router.py.
    • Add yaml.py in common/utils to define dump and load functions using ruamel.yaml.
  • Code Cleanup:
    • Remove unused imports in excecute_api_call.py and execute_system.py.
    • Fix None comparison in execute_system.py.
    • Remove unused exception variable in update_execution.py.
  • Dependencies:
    • Remove pyyaml and add ruamel-yaml in pyproject.toml.

This description was created by Ellipsis for 0854ead. It will automatically update as commits are pushed.

Signed-off-by: Diwank Singh Tomer <[email protected]>
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0854ead in 26 seconds

More details
  • Looked at 253 lines of code in 12 files
  • Skipped 3 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. agents-api/agents_api/activities/utils.py:52
  • Draft comment:
    Ensure that yaml.load is used correctly with the new yaml module from ruamel.yaml. The CSafeLoader is no longer applicable.
  • Reason this comment was not posted:
    Marked as duplicate.
2. agents-api/agents_api/activities/utils.py:75
  • Draft comment:
    Ensure that yaml.load and yaml.dump are used correctly with the new yaml module from ruamel.yaml. The CSafeLoader and CSafeDumper are no longer applicable.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_ftZ0jnGTvAwowlnT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit 0855438 into dev Oct 15, 2024
10 of 14 checks passed
@creatorrr creatorrr deleted the x/use-ruamel branch October 15, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant