Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agents-api): Fix Box/BoxList problem in system calls #652

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Oct 15, 2024

  • fix: Fix BoxList problem with vectors
  • fix(agents-api): Fix Box/BoxList problem in system calls

Important

Fixes handling of Box and BoxList in execute_system() and updates .gitignore for JupyterLab.

  • Behavior:
    • Fixes handling of Box and BoxList in execute_system() in execute_system.py by converting them to dictionaries and lists respectively.
    • Commented out assertion in validate_transition_targets() in create_execution_transition.py for finish, error, and cancelled cases.
  • Misc:
    • Adds .virtual_documents/ to .gitignore for JupyterLab.

This description was created by Ellipsis for 0f993d7. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0f993d7 in 17 seconds

More details
  • Looked at 73 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. agents-api/agents_api/activities/execute_system.py:53
  • Draft comment:
    Consider using a helper function to unbox Box and BoxList types to avoid code repetition and improve readability.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR introduces a fix for handling Box and BoxList types by converting them to dictionaries and lists, respectively. This is a good practice to ensure compatibility with other parts of the code that may not handle these types. However, the code could be optimized by using a helper function to avoid repetition.
2. agents-api/agents_api/models/execution/create_execution_transition.py:34
  • Draft comment:
    The FIXME comment indicates a hack that needs to be addressed. Ensure this is resolved before merging.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_cUa4fTkmOcZQhg13


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit 24c2bd5 into dev Oct 15, 2024
5 of 7 checks passed
@creatorrr creatorrr deleted the x/system-call-box branch October 15, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants