Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agents-api): Install gcc/g++ and other dependencies #692

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

HamadaSalhab
Copy link
Contributor

@HamadaSalhab HamadaSalhab commented Oct 17, 2024

Important

Add system dependencies in Dockerfile and Dockerfile.worker to support building Python packages with native extensions.

  • Dependencies:
    • Install gcc, g++, and development libraries in Dockerfile and Dockerfile.worker to support building Python packages with native extensions.
    • Libraries include libssl-dev, libffi-dev, libbz2-dev, among others.
  • Dockerfiles:
    • Update Dockerfile and Dockerfile.worker to include new dependencies.

This description was created by Ellipsis for 4007541. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to f6224a2 in 27 seconds

More details
  • Looked at 36 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_Gl3AYARrJaFFehi3


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

agents-api/Dockerfile.worker Outdated Show resolved Hide resolved
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 4007541 in 15 seconds

More details
  • Looked at 69 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/Dockerfile.worker:40
  • Draft comment:
    The poetry install --no-dev command is redundant after poetry install --no-dev --no-root. Consider removing it to optimize the Dockerfile.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_ZUMal8JswQXpRDng


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit e2f1b49 into dev Oct 17, 2024
7 of 11 checks passed
@creatorrr creatorrr deleted the x/worker-packages-installation branch October 17, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants