Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Fix agent.about in jinja templates #694

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

Ahmad-mtos
Copy link
Contributor

@Ahmad-mtos Ahmad-mtos commented Oct 18, 2024

While reviewing the codebase, I noticed this bug in Jinja template.


Important

Fixes Jinja template bug by replacing agent.name with agent.about in relevant files.

  • Bug Fix:
    • Corrects Jinja template variable from agent.name to agent.about in default_system_template.md, julep-concepts.md, and constants.tsp.
    • Ensures agent.about is correctly displayed in templates when available.

This description was created by Ellipsis for 463a0e6. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 463a0e6 in 19 seconds

More details
  • Looked at 41 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docs/explanation/default_system_template.md:18
  • Draft comment:
    Correctly changed {{agent.name}} to {{agent.about}} to display the agent's description instead of its name. This change is consistent with the intended use of agent.about.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR correctly fixes the Jinja template to use agent.about instead of agent.name in the 'About you' section. This change is consistent across all modified files.

Workflow ID: wflow_jgra9nLBhg3wmTwb


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ijindal1
Copy link
Contributor

@whiterabbit1983 - can you review this and merge it?

@whiterabbit1983
Copy link
Contributor

whiterabbit1983 commented Oct 18, 2024

@Ahmad-mtos the PR is incomplete. You have to re-compile the spec every time you change the tsp file. You can do it as follows:

$ npm i -g @typespec/compiler
$ cd typespec; npm i
$ cd ../agents-api; poetry install
$ cd ..
$ ./scripts/generate_openapi_code.sh

You need to have NodeJS/npm and poetry (Python package manager) installed. After you run all the commands above, you gonna see some changed, just push them upstream

@Ahmad-mtos
Copy link
Contributor Author

@whiterabbit1983 done, thanks for the instructions

@whiterabbit1983 whiterabbit1983 merged commit 81df5be into julep-ai:dev Oct 18, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants