-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D/cookbookfix: cookbooks bugs fixed for 5,10,11. And files renamed according to naming convention #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 7cdfd86 in 34 seconds
More details
- Looked at
254
lines of code in6
files - Skipped
3
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. cookbooks/11-Advanced_Chat_Interactions.py:75
- Draft comment:
Replace the hardcoded API key placeholder with a secure method of storing and accessing API keys, such as environment variables. - Reason this comment was not posted:
Marked as duplicate.
2. cookbooks/05-Basic_Agent_Creation_and_Interaction.py:1
- Draft comment:
Replace the hardcoded API key placeholder with a secure method of storing and accessing API keys, such as environment variables. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_beRSIgWV9obFLxT9
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fix bugs in cookbooks 5, 10, 11 and rename files for consistency.
05-Basic_Agent_Creation_and_Interaction.py
: Fix session creation by removingcontext_overflow
parameter and correct chat history retrieval.10-Document_Management_and_Search.py
: Removefilters
from search input and fix document search output handling.11-Advanced_Chat_Interactions.py
: Adjust chat logic for weather information and improve context management.14_automated_webinar_scheduling_workflow.py
to14-Automated_Webinar_Scheduling_Workflow.py
.15_personal_finance_tracker.py
to15-Personal_Finance_Tracker.py
.e_commerce_order_processing_workflow.py
to16-E_commerce_Order_Processing_Workflow.py
.This description was created by for 7cdfd86. It will automatically update as commits are pushed.