Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D/cookbookfix: cookbooks bugs fixed for 5,10,11. And files renamed according to naming convention #707

Merged
merged 17 commits into from
Oct 19, 2024

Conversation

Vedantsahai18
Copy link
Member

@Vedantsahai18 Vedantsahai18 commented Oct 18, 2024

Important

Fix bugs in cookbooks 5, 10, 11 and rename files for consistency.

  • Behavior:
    • 05-Basic_Agent_Creation_and_Interaction.py: Fix session creation by removing context_overflow parameter and correct chat history retrieval.
    • 10-Document_Management_and_Search.py: Remove filters from search input and fix document search output handling.
    • 11-Advanced_Chat_Interactions.py: Adjust chat logic for weather information and improve context management.
  • Renames:
    • Rename 14_automated_webinar_scheduling_workflow.py to 14-Automated_Webinar_Scheduling_Workflow.py.
    • Rename 15_personal_finance_tracker.py to 15-Personal_Finance_Tracker.py.
    • Rename e_commerce_order_processing_workflow.py to 16-E_commerce_Order_Processing_Workflow.py.

This description was created by Ellipsis for 7cdfd86. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 7cdfd86 in 34 seconds

More details
  • Looked at 254 lines of code in 6 files
  • Skipped 3 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. cookbooks/11-Advanced_Chat_Interactions.py:75
  • Draft comment:
    Replace the hardcoded API key placeholder with a secure method of storing and accessing API keys, such as environment variables.
  • Reason this comment was not posted:
    Marked as duplicate.
2. cookbooks/05-Basic_Agent_Creation_and_Interaction.py:1
  • Draft comment:
    Replace the hardcoded API key placeholder with a secure method of storing and accessing API keys, such as environment variables.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_beRSIgWV9obFLxT9


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

cookbooks/11-Advanced_Chat_Interactions.py Show resolved Hide resolved
cookbooks/11-Advanced_Chat_Interactions.py Show resolved Hide resolved
@creatorrr creatorrr merged commit e341fb1 into dev Oct 19, 2024
9 of 10 checks passed
@creatorrr creatorrr deleted the d/cookbookfix branch October 19, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants