-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agents-api,integrations): Misc fixes and tenacity retry in integrations" #710
Conversation
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 54e04a0 in 30 seconds
More details
- Looked at
483
lines of code in25
files - Skipped
1
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. integrations-service/integrations/utils/integrations/wikipedia.py:12
- Draft comment:
Consider making thesearch
function asynchronous if it is intended to be used in an async context. - Reason this comment was not posted:
Confidence changes required:50%
Thesearch
function inintegrations-service/integrations/utils/integrations/wikipedia.py
is defined as a synchronous function but is being used in an asynchronous context. This could lead to issues if the function is expected to be awaited.
2. integrations-service/integrations/routers/execution/execute.py:22
- Draft comment:
Rename one of theexecute
functions to avoid name collision and potential logical errors. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment points out a potential issue with having two functions with the same name, which could lead to confusion or errors in the future. While Python allows function overloading based on parameters, having two functions with the same name in the same file can be confusing for developers. The comment is actionable and suggests a clear refactor to improve code quality.
The functions are differentiated by their parameters, so technically there is no collision in Python. However, the comment is about code readability and maintainability, which is a valid concern.
Even though Python allows this, the comment is about improving code readability and maintainability, which is important for long-term code quality.
The comment is valid as it suggests a code quality improvement by renaming one of the 'execute' functions to avoid confusion, even though there is no technical collision.
Workflow ID: wflow_sYSlkeTSIE0c1ioX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 55fe24a in 11 seconds
More details
- Looked at
25
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. .github/workflows/translate-readme.yml:45
- Draft comment:
Add a newline at the end of the file for better compatibility with Unix-based systems. - Reason this comment was not posted:
Confidence changes required:33%
The workflow file is missing a newline at the end, which is a best practice for text files.
Workflow ID: wflow_2eR9dQ5Uix4Zh2OW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add
tenacity
retry logic to integration functions, remove unused integrations, and improve agents-api and integrations services.tenacity
retry logic tosearch()
inbrave.py
,load()
inbrowserbase.py
,send()
inemail.py
,crawl()
inspider.py
,get()
inweather.py
, andsearch()
inwikipedia.py
.dalle_image_generator.py
,duckduckgo_search.py
,gmail/send_mail.py
,hacker_news.py
, andrequest.py
.hacker_news
provider fromproviders.py
.log_step()
inlog_step.py
to includeinclude_remote=True
incontext.model_dump()
.NEWLINE
constant toutils.py
andtemplate.py
.ApplicationError
to non-retryable exceptions ininterceptors.py
.test_doc()
infixtures.py
from 0.1 to 0.5 seconds.base_models.py
,email.py
,wikipedia.py
,get_integration.py
, andexecute_integration.py
.tenacity
topyproject.toml
dependencies.This description was created by for 55fe24a. It will automatically update as commits are pushed.