Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agents-api): Increase timeout to 60s for executing integration activity #726

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

HamadaSalhab
Copy link
Contributor

@HamadaSalhab HamadaSalhab commented Oct 21, 2024

Important

Increase timeout to 60 seconds for AsyncClient in run_integration_service to allow longer execution times.

  • Behavior:
    • Increase timeout to 60 seconds for AsyncClient in run_integration_service function in integrations.py to allow longer execution times for integration activities.

This description was created by Ellipsis for f62a392. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f62a392 in 5 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/clients/integrations.py:24
  • Draft comment:
    Consider making the timeout value configurable instead of hardcoding it to 60 seconds. This will provide more flexibility for different environments or use cases.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change to increase the timeout is appropriate, but it's important to ensure that the timeout is configurable for flexibility.

Workflow ID: wflow_Mj7EtUix89uvw585


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@HamadaSalhab HamadaSalhab merged commit dd7480e into dev Oct 21, 2024
13 checks passed
@HamadaSalhab HamadaSalhab deleted the f/integration-timeout branch October 21, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant