-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(typespec): Use typespec generated models #766
Conversation
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to a2b1a4f in 1 minute and 20 seconds
More details
- Looked at
7979
lines of code in67
files - Skipped
2
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. agents-api/agents_api/activities/execute_integration.py:7
- Draft comment:
The type of theintegration
parameter should be updated toBaseIntegrationDef
in the function signature to reflect the change in the function body. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is accurate as it points out a change that was made in the diff. The type of the 'integration' parameter was updated in the function signature, which aligns with the comment's suggestion. This is a clear and actionable comment related to the code change.
The comment might be seen as stating the obvious since the change is already made in the diff. However, it does confirm that the change aligns with the intended update.
While the change is already made, the comment serves as a confirmation that the update was necessary and correctly implemented.
The comment is correct and relevant to the change made in the diff. It should be kept as it confirms the update to the function signature.
2. agents-api/agents_api/autogen/Agents.py:28
- Draft comment:
Ensure that the pattern constraint for thename
field does not conflict with the empty string default value. - Reason this comment was not posted:
Confidence changes required:50%
The removal of the default value for thename
field in theAgent
class and similar classes is a good change as it aligns with the Pydantic best practices for default values. However, the pattern constraint should be checked to ensure it doesn't conflict with the empty string default.
3. agents-api/agents_api/workflows/task_execution/__init__.py:18
- Draft comment:
The type of theintegration
parameter should be updated toBaseIntegrationDef
in the function signature to reflect the change in the function body. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_NknjuUiEgzVIWybr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 191b319 in 43 seconds
More details
- Looked at
122
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. .github/workflows/lint-integrations-service-pr.yml:57
- Draft comment:
Add a newline at the end of the file for POSIX compliance. - Reason this comment was not posted:
Confidence changes required:10%
The GitHub Actions workflows for linting and testing are well-structured, but they both lack a newline at the end of the file. This is a minor issue but considered a best practice for POSIX compliance.
2. .github/workflows/test-integrations-service-pr.yml:50
- Draft comment:
Add a newline at the end of the file for POSIX compliance. - Reason this comment was not posted:
Confidence changes required:10%
The GitHub Actions workflows for linting and testing are well-structured, but they both lack a newline at the end of the file. This is a minor issue but considered a best practice for POSIX compliance.
Workflow ID: wflow_aEjJIeaWW3GlMNCe
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Refactor integration models to use typespec-generated models, add granular integration definitions, update agents API, and configure CI for linting and testing.
execute_integration()
inexecute_integration.py
to useBaseIntegrationDef
instead ofIntegrationDef
.browserbase
andhacker_news
.BaseIntegrationDef
and specific integration models likeBraveIntegrationDef
,EmailIntegrationDef
, etc.BraveProviderCard
,EmailProviderCard
, etc.lint-integrations-service-pr.yml
andtest-integrations-service-pr.yml
for CI linting and testing.pyproject.toml
to usedatamodel-code-generator
version0.26.2
.__main__.py
tointegrations-service
for entry point.wikipedia
integration.This description was created by for 191b319. It will automatically update as commits are pushed.