Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typespec): Add types for browserbase tools #774

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Oct 29, 2024

Signed-off-by: Diwank Singh Tomer [email protected]


Important

Adds types and integration definitions for browserbase tools, focusing on session management and context creation.

  • Behavior:
    • Adds types for browserbase tools in Tools.py and main.tsp.
    • Introduces session management and context creation methods.
  • Models:
    • Adds BrowserbaseCreateSessionArguments, BrowserbaseGetSessionArguments, and other session-related models in Tools.py.
    • Adds BaseBrowserbaseIntegrationDef and BrowserbaseContextIntegrationDef models.
  • Integration:
    • Updates CreateToolRequest, PatchToolRequest, Tool, and UpdateToolRequest to include browserbase integration definitions.
    • Adds BrowserbaseProviderCard in main.tsp to define provider methods.
  • Misc:
    • Adds contexts.tsp, extensions.tsp, and sessions.tsp for browserbase tool specifications.
    • Updates OpenAPI spec in openapi-1.0.0.yaml to include new browserbase components.

This description was created by Ellipsis for c84c935. It will automatically update as commits are pushed.

Copy link
Contributor

sweep-ai bot commented Oct 29, 2024

Hey @creatorrr, here are examples of how you can ask me to improve this pull request:

@Sweep Fix the CI errors.
@Sweep Add unit tests for BrowserbaseCreateSessionArguments model validation that test:
- Required projectId field
- Optional fields like extensionId, browserSettings, timeout, keepAlive
- Validation of timeout as uint16
- Validation of proxies field accepting both boolean and array types

📖 For more information on how to use Sweep, please read our documentation.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c84c935 in 1 minute and 23 seconds

More details
  • Looked at 1803 lines of code in 9 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. agents-api/agents_api/autogen/Tools.py:352
  • Draft comment:
    The use of Annotated is unnecessary here since no additional metadata or constraints are being applied. Consider removing Annotated for clarity. This applies to other similar instances in this file as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The use of Annotated is unnecessary when there are no additional metadata or constraints being applied. This is a minor issue but should be addressed for code clarity and consistency.
2. integrations-service/integrations/autogen/Tools.py:352
  • Draft comment:
    The use of Annotated is unnecessary here since no additional metadata or constraints are being applied. Consider removing Annotated for clarity. This applies to other similar instances in this file as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The use of Annotated is unnecessary when there are no additional metadata or constraints being applied. This is a minor issue but should be addressed for code clarity and consistency.

Workflow ID: wflow_WVDVUYmawhY8SeMu


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit 101be27 into dev Oct 29, 2024
15 of 18 checks passed
@creatorrr creatorrr deleted the f/browserbase-types branch October 29, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant