fix(agents-api & integrations-service): Fix Browserbase/RemoteBrowser integrations #784

HamadaSalhab · 2024-10-30T18:51:43Z

Important

Fixes Browserbase and RemoteBrowser integrations by adding new fields, making arguments optional, and changing URL types.

Behavior:
- Add project_id, api_url, and connect_url fields to BrowserbaseSetup and BrowserbaseSetupUpdate in Tools.py.
- Make arguments optional in several IntegrationDef classes in Tools.py.
- Change connect_url type from AnyUrl to str in RemoteBrowserSetup and RemoteBrowserSetupUpdate in Tools.py.
Models:
- Update SessionInfo, BrowserbaseCreateSessionOutput, and BrowserbaseGetSessionOutput in browserbase.py to allow None for several fields.
- Add BrowserbaseContextOutput to browserbase.py.
- Update ExecutionArguments and ExecutionResponse in execution.py to include new Browserbase and RemoteBrowser models.
Misc:
- Remove unused imports in get_integrations.py and execute_integration.py.
- Add project_id, api_url, and connect_url to get_browserbase_client() in browserbase.py.

^{This description was created by}^{for 40734ad. It will automatically update as commits are pushed.}

sweep-ai · 2024-10-30T18:51:52Z

Hey @HamadaSalhab, here is an example of how you can ask me to improve this pull request:

@Sweep Add unit tests for the `get_browserbase_client` function in `browserbase.py` to verify it correctly initializes the Browserbase client with the new optional parameters (project_id, api_url, connect_url).

📖 For more information on how to use Sweep, please read our documentation.

Signed-off-by: Diwank Singh Tomer <[email protected]>

ellipsis-dev

👍 Looks good to me! Reviewed everything up to 90d7b30 in 46 seconds

More details

Looked at 877 lines of code in 12 files
Skipped 0 files when reviewing.
Skipped posting 3 drafted comments based on config settings.

1. agents-api/agents_api/autogen/Tools.py:1147

Draft comment:
Changing connect_url from AnyUrl to str removes automatic URL validation. Ensure URL validation is handled elsewhere to prevent invalid URLs.
Reason this comment was not posted:
Comment did not seem useful.

2. integrations-service/integrations/autogen/Tools.py:1147

Draft comment:
Changing connect_url from AnyUrl to str removes automatic URL validation. Ensure URL validation is handled elsewhere to prevent invalid URLs.
Reason this comment was not posted:
Marked as duplicate.

3. integrations-service/integrations/utils/integrations/browserbase.py:110

Draft comment:
Consider logging the exception details in the except block for better debugging and traceability.
Reason this comment was not posted:
Confidence changes required: 50%
The exception handling in complete_session should log the exception details for better debugging and traceability.

Workflow ID: wflow_wJIVgWLKllCCvs4C

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

creatorrr · 2024-10-31T05:20:00Z

Made some fixes. Tested browserbase.list_sessions integration, which works now. Not tested the rest yet @HamadaSalhab

Made changes so that a fully typed JSON object is returned by Brave Search . This fixes issue #771  ---- > [!IMPORTANT] > Parse Brave Search JSON output into `SearchResult` objects and update `BraveSearchOutput` to return a list of these objects. > > - **Behavior**: > - `search()` in `brave.py` now parses JSON results into `SearchResult` objects. > - `BraveSearchOutput` now returns a list of `SearchResult` instead of a single string. > - **Models**: > - Adds `SearchResult` model in `brave.py` with `title`, `link`, and `snippet` fields. > - Updates `BraveSearchOutput` in `brave.py` to use `List[SearchResult]` for `result`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=julep-ai%2Fjulep&utm_source=github&utm_medium=referral)<sup> for 61e813a. It will automatically update as commits are pushed.</sup>  --------- Co-authored-by: Diwank Singh Tomer <[email protected]> Co-authored-by: vedantsahai18 <[email protected]>

ellipsis-dev

👍 Looks good to me! Incremental review on 9ab7f86 in 22 seconds

More details

Looked at 31 lines of code in 1 files
Skipped 0 files when reviewing.
Skipped posting 1 drafted comments based on config settings.

1. integrations-service/integrations/models/execution.py:32

Draft comment:
BrowserbaseContextOutput is commented out here and in ExecutionResponse. Ensure this is intentional and not an oversight, as the PR description mentions adding it to browserbase.py.
Reason this comment was not posted:
Confidence changes required: 50%
The comment is about the removal of BrowserbaseContextOutput from the imports and usage in ExecutionResponse. This is consistent with the PR description, which mentions adding BrowserbaseContextOutput to browserbase.py, but it seems to be commented out here. This might be intentional, but it's worth pointing out in case it was overlooked.

Workflow ID: wflow_ETLdqnE3i3CsipE0

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Signed-off-by: Diwank Singh Tomer <[email protected]>

ellipsis-dev

👍 Looks good to me! Incremental review on 4e77450 in 30 seconds

More details

Looked at 373 lines of code in 8 files
Skipped 0 files when reviewing.
Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_AGUarFvuxTQA0tp6

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

ellipsis-dev

👍 Looks good to me! Incremental review on a18f853 in 25 seconds

More details

Looked at 77 lines of code in 2 files
Skipped 0 files when reviewing.
Skipped posting 2 drafted comments based on config settings.

1. integrations-service/integrations/models/browserbase.py:6

Draft comment:
The import of Session from browserbase is unused and can be removed to clean up the code.
Reason this comment was not posted:
Confidence changes required: 10%
The import statement for Session from browserbase is unnecessary in integrations-service/integrations/models/browserbase.py since it is not used in the file.

2. integrations-service/integrations/utils/integrations/browserbase.py:28

Draft comment:
The import of Session from browserbase is unused and can be removed to clean up the code.
Reason this comment was not posted:
Confidence changes required: 10%
The import statement for Session from browserbase is unnecessary in integrations-service/integrations/utils/integrations/browserbase.py since it is not used in the file.

Workflow ID: wflow_AcF09iyyckkfStS4

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

…-ai/julep into x/browserbase-integrations

integrations-service/integrations/providers.py

…-ai/julep into x/browserbase-integrations

ellipsis-dev

❌ Changes requested. Incremental review on 40734ad in 32 seconds

More details

Looked at 34 lines of code in 1 files
Skipped 0 files when reviewing.
Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_VxPIDIggKNwYAjRo

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

integrations-service/integrations/utils/integrations/remote_browser.py

HamadaSalhab and others added 2 commits October 30, 2024 21:49

Fix new integrations

9ed1eb2

refactor: Lint integrations-service (CI)

03b587e

creatorrr and others added 3 commits October 31, 2024 00:11

Merge branch 'dev' into x/browserbase-integrations

a75c813

fix(integrations): Fix browserbase integration provider

9af3e8d

Signed-off-by: Diwank Singh Tomer <[email protected]>

refactor: Lint integrations-service (CI)

90d7b30

creatorrr marked this pull request as ready for review October 31, 2024 04:59

ellipsis-dev bot reviewed Oct 31, 2024

View reviewed changes

creatorrr and others added 4 commits October 31, 2024 01:20

Merge branch 'dev' into x/browserbase-integrations

7f7091f

Merge branch 'dev' into x/browserbase-integrations

15c110a

fix circular import issue

9ab7f86

ellipsis-dev bot reviewed Oct 31, 2024

View reviewed changes

fix(integrations): Fix browserbase.create_session

4e77450

Signed-off-by: Diwank Singh Tomer <[email protected]>

ellipsis-dev bot reviewed Oct 31, 2024

View reviewed changes

Fix browserbase list session integration

a18f853

ellipsis-dev bot reviewed Oct 31, 2024

View reviewed changes

HamadaSalhab and others added 8 commits October 31, 2024 19:33

refactor: Lint integrations-service (CI)

15d95a1

Fix browserbase get_session_live_urls

026bd4b

Merge branch 'x/browserbase-integrations' of https://github.com/julep…

02c6dd9

…-ai/julep into x/browserbase-integrations

refactor: Lint integrations-service (CI)

1d0ff4b

Fix browserbase get_sesion_connect_url

318dd0a

Merge branch 'x/browserbase-integrations' of https://github.com/julep…

a41ae86

…-ai/julep into x/browserbase-integrations

Merge branch 'dev' into x/browserbase-integrations

fd83447

refactor: Lint integrations-service (CI)

e3b7685

creatorrr reviewed Oct 31, 2024

View reviewed changes

integrations-service/integrations/providers.py Outdated Show resolved Hide resolved

HamadaSalhab and others added 3 commits November 1, 2024 00:29

Fix typos

6836152

Merge branch 'x/browserbase-integrations' of https://github.com/julep…

6a9e996

…-ai/julep into x/browserbase-integrations

refactor: Lint integrations-service (CI)

60d69ec

HamadaSalhab and others added 4 commits November 1, 2024 00:36

Change github url link to point to tags

a149add

Merge branch 'x/browserbase-integrations' of https://github.com/julep…

94d6866

…-ai/julep into x/browserbase-integrations

refactor: Lint integrations-service (CI)

e3ad5ac

Fix session disconnection after performing remote action

40734ad

ellipsis-dev bot reviewed Oct 31, 2024

View reviewed changes

integrations-service/integrations/utils/integrations/remote_browser.py Show resolved Hide resolved

HamadaSalhab merged commit 1f8fe30 into dev Oct 31, 2024
14 checks passed

HamadaSalhab deleted the x/browserbase-integrations branch October 31, 2024 23:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(agents-api & integrations-service): Fix Browserbase/RemoteBrowser integrations #784

fix(agents-api & integrations-service): Fix Browserbase/RemoteBrowser integrations #784

HamadaSalhab commented Oct 30, 2024 •

edited by ellipsis-dev bot

Loading

sweep-ai bot commented Oct 30, 2024 •

edited

Loading

ellipsis-dev bot left a comment

creatorrr commented Oct 31, 2024

ellipsis-dev bot left a comment

ellipsis-dev bot left a comment

ellipsis-dev bot left a comment

ellipsis-dev bot left a comment

fix(agents-api & integrations-service): Fix Browserbase/RemoteBrowser integrations #784

fix(agents-api & integrations-service): Fix Browserbase/RemoteBrowser integrations #784

Conversation

HamadaSalhab commented Oct 30, 2024 • edited by ellipsis-dev bot Loading

sweep-ai bot commented Oct 30, 2024 • edited Loading

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

creatorrr commented Oct 31, 2024

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

HamadaSalhab commented Oct 30, 2024 •

edited by ellipsis-dev bot

Loading

sweep-ai bot commented Oct 30, 2024 •

edited

Loading