-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agents-api): Add support for claude computer-use #787
Conversation
Hey @creatorrr, here is an example of how you can ask me to improve this pull request: @Sweep Add unit tests for the `format_agent_tool` function in `prompt_step.py` to verify correct formatting for each tool type: 📖 For more information on how to use Sweep, please read our documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to efc9376 in 51 seconds
More details
- Looked at
399
lines of code in7
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_pmG9hYHbuFufaji2
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 5867ecb in 22 seconds
More details
- Looked at
121
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. agents-api/agents_api/activities/task_steps/prompt_step.py:9
- Draft comment:
Redundant import ofModelResponse
fromlitellm.utils
. It's already imported fromlitellm.types.utils
. Consider removing one of them. - Reason this comment was not posted:
Confidence changes required:50%
The import ofModelResponse
fromlitellm.utils
is redundant since it's already imported fromlitellm.types.utils
. This can lead to confusion and should be cleaned up.
2. agents-api/agents_api/activities/task_steps/prompt_step.py:189
- Draft comment:
Consider usingdatetime.utcnow().timestamp()
instead ofdatetime.now().timestamp()
to avoid potential timezone issues. - Reason this comment was not posted:
Confidence changes required:33%
Theprompt_step
function usesdatetime.now().timestamp()
to get the current timestamp. This is generally fine, but if the application is timezone-sensitive, it might be better to usedatetime.utcnow().timestamp()
to avoid any potential issues with local timezones.
Workflow ID: wflow_Jr4gFzuzZalpbe5Q
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Adds support for Anthropic Claude model with new tool types, updates models, and fixes a bug in
execute_system.py
.computer_20241022
,text_editor_20241022
, andbash_20241022
tools inprompt_step.py
.type
field toTool
,CreateToolRequest
,PatchToolRequest
, andUpdateToolRequest
models.ToolType
enum to include new tool types.execute_system.py
related todelete
operation handling.AsyncAnthropic
inprompt_step.py
for asynchronous API calls.This description was created by for 5867ecb. It will automatically update as commits are pushed.