Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Misc improvements to types and stdlib in jinja #788

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Oct 31, 2024

Closes #723

Signed-off-by: Diwank Singh Tomer [email protected]


Important

This PR updates type definitions, modifies default values, and enhances Jinja environment setup for improved functionality and maintainability.

  • Behavior:
    • Changed default value of inherit_tools to false in CreateTaskRequest, PatchTaskRequest, and UpdateTaskRequest in Tasks.py and Tools.py.
    • Added label field to various workflow step models in Tasks.py for step referencing.
    • Updated id type from UUID to string in ToolRefById and ToolResponse in Tools.py.
  • Jinja Environment:
    • Consolidated Jinja environment globals setup in template.py using constants, stdlib, and ALLOWED_FUNCTIONS.
  • Misc:
    • Added schema_ field to ApiCallDef in Tools.py for response schema definition.
    • Updated litellm version in pyproject.toml to ^1.51.2.
    • Marked a test as skipped in test_docs_routes.py due to random CI failures.

This description was created by Ellipsis for 1b0f870. It will automatically update as commits are pushed.

Copy link
Contributor

sweep-ai bot commented Oct 31, 2024

Hey @creatorrr, here is an example of how you can ask me to improve this pull request:

@Sweep Add unit tests for the consolidated Jinja environment setup in `template.py` to verify that all expected globals (constants, stdlib, and ALLOWED_FUNCTIONS) are properly loaded and accessible in the Jinja environment.

📖 For more information on how to use Sweep, please read our documentation.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1b0f870 in 54 seconds

More details
  • Looked at 1253 lines of code in 13 files
  • Skipped 1 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. agents-api/agents_api/autogen/Tools.py:1485
  • Draft comment:
    Changing the 'id' field from UUID to string might cause compatibility issues if other parts of the codebase expect a UUID. Ensure this change is consistent across the codebase.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. integrations-service/integrations/autogen/Tools.py:1485
  • Draft comment:
    Changing the 'id' field from UUID to string might cause compatibility issues if other parts of the codebase expect a UUID. Ensure this change is consistent across the codebase.
  • Reason this comment was not posted:
    Marked as duplicate.
3. typespec/tasks/models.tsp:37
  • Draft comment:
    Changing the 'id' field from UUID to string might cause compatibility issues if other parts of the codebase expect a UUID. Ensure this change is consistent across the codebase.
  • Reason this comment was not posted:
    Marked as duplicate.
4. typespec/tools/models.tsp:253
  • Draft comment:
    Changing the 'id' field from UUID to string might cause compatibility issues if other parts of the codebase expect a UUID. Ensure this change is consistent across the codebase.
  • Reason this comment was not posted:
    Marked as duplicate.
5. typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml:5498
  • Draft comment:
    Changing the 'id' field from UUID to string might cause compatibility issues if other parts of the codebase expect a UUID. Ensure this change is consistent across the codebase.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_j8XDmaT9gekTu48T


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit 2b635cf into dev Oct 31, 2024
16 of 18 checks passed
@creatorrr creatorrr deleted the f/misc-improvements branch October 31, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: stdlib calls in prompt step
1 participant