fix(agents-api): Fix blob store, ifelse branch, temporal postgres

[creatorrr]

Important

Fixes blob store handling, improves retry logic, and updates configurations for agents API, memory store, and scheduler.

• Blob Store Handling:
  • In execute_system.py, added logic to load arguments from blob store if they contain bucket and key.
  • In storage_handler.py, updated load_from_blob_store_if_remote() to handle dicts with bucket and key.
• Retry Logic:
  • In models/utils.py, increased retry attempts from 2 to 4 in is_resource_busy().
  • Updated error handling in cozo_query() to check both e and e.resp for 'busy' status.
• Workflow Execution:
  • In helpers.py, modified execute_if_else_branch() to handle None else_branch by setting a default EvaluateStep.
• Configuration Updates:
  • In memory-store/docker-compose.yml, added develop section for file watching and rebuild actions.
  • In memory-store/options, increased max_background_jobs to 32 and max_subcompactions to 8.
  • In scheduler/docker-compose.yml, set temporal-db-data volume to external.

^{This description was created by for fa011a9. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to fa011a9 in 32 seconds

More details

• Looked at 167 lines of code in 7 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. agents-api/agents_api/models/utils.py:216

• Draft comment:
  The retry policy has been updated to stop_after_attempt(4), ensuring consistency with other retry policies in the codebase.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The PR modifies the retry policy in cozo_query decorator to increase the number of attempts from 2 to 4. This change is reflected in the stop_after_attempt parameter. The change is consistent with the retry policy in the cozo_query_dec function, which also uses stop_after_attempt(4). This ensures consistency in retry behavior across the codebase.

2. agents-api/agents_api/common/storage_handler.py:47

• Draft comment:
  The function now handles dictionaries with bucket and key keys, consistent with its usage in execute_system.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The PR modifies the load_from_blob_store_if_remote function to handle a dictionary with keys bucket and key. This change is consistent with the usage in execute_system function, where arguments with these keys are passed to load_from_blob_store_if_remote. This ensures that the function can handle such cases correctly.

3. agents-api/agents_api/workflows/task_execution/helpers.py:102

• Draft comment:
  Handles None for else_branch by assigning a default EvaluateStep, ensuring graceful handling of missing branches.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The PR modifies the execute_if_else_branch function to handle a None value for else_branch. This change ensures that the function can handle cases where the else_branch is not provided, by assigning a default EvaluateStep. This is a logical improvement to handle such cases gracefully.

4. memory-store/docker-compose.yml:19

• Draft comment:
  Added develop section with watch configuration for automatic sync and restart, useful for development environments.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The PR adds a develop section in the docker-compose.yml for memory-store, which includes a watch configuration. This allows for automatic syncing and restarting when changes are detected in the specified paths. This is a useful addition for development environments to ensure changes are reflected without manual intervention.

Workflow ID: wflow_LPMM6nltlrXi1Dka

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.