Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agents-api): Add label lookup for inputs and outputs #906

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Ahmad-mtos
Copy link
Contributor

@Ahmad-mtos Ahmad-mtos commented Nov 28, 2024

closes #791


Important

Add label lookup for inputs and outputs in agents API by updating StepContext and workflow execution methods.

  • Behavior:
    • Add labels attribute to StepContext in tasks.py for label lookup in inputs and outputs.
    • Update prepare_for_step in tasks.py to merge labels with inputs and outputs.
  • Workflow Execution:
    • Modify run method in __init__.py to handle previous_labels for task execution.
    • Update continue_as_child in helpers.py to accept previous_labels parameter.

This description was created by Ellipsis for 9a3cfd0. It will automatically update as commits are pushed.

@Ahmad-mtos Ahmad-mtos requested a review from creatorrr November 28, 2024 15:44
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 9a3cfd0 in 41 seconds

More details
  • Looked at 102 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/workflows/task_execution/__init__.py:140
  • Draft comment:
    Initializing previous_labels as an empty dictionary if not provided is consistent with the changes for label lookup. This logic is correct.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The run method in TaskExecutionWorkflow class initializes previous_labels as an empty dictionary if not provided. This is consistent with the changes made to support label lookup for inputs and outputs. The logic seems correct here.

Workflow ID: wflow_iVQFZayAMbHKoGjo


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add label lookup for inputs and outputs in tasks
1 participant