-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F/migrate workflows to pg #989
Conversation
CI Failure Feedback 🧐(Checks updated until commit c0acb49)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14144715 | Triggered | Generic Password | 7798826 | memory-store/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to c0acb49 in 1 minute and 31 seconds
More details
- Looked at
8596
lines of code in96
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. agents-api/agents_api/worker/worker.py:55
- Draft comment:
TheEmbedDocsWorkflow
is not included in the worker initialization. Ensure this is intentional and not an oversight due to the migration to PostgreSQL. - Reason this comment was not posted:
Confidence changes required:50%
Thecreate_worker
function inworker.py
initializes a Temporal worker but does not include theEmbedDocsWorkflow
. This might be intentional due to the migration to PostgreSQL, but it's worth noting in case it was an oversight.
2. agents-api/agents_api/routers/docs/create_doc.py:46
- Draft comment:
TheEmbedDocsWorkflow
is no longer started increate_user_doc
. Ensure this change aligns with the intended functionality after migrating to PostgreSQL. - Reason this comment was not posted:
Confidence changes required:50%
Thecreate_user_doc
andcreate_agent_doc
functions increate_doc.py
no longer start theEmbedDocsWorkflow
. This is likely due to the migration to PostgreSQL, but it's important to confirm that this change aligns with the intended functionality.
3. agents-api/docker-compose.yml:11
- Draft comment:
Ensure that the transition from Cozo to PostgreSQL configurations is complete and correct, as this is a significant change. - Reason this comment was not posted:
Confidence changes required:50%
Thedocker-compose.yml
for theagents-api
service has removed thecozo
related environment variables and services, replacing them with PostgreSQL configurations. This is a significant change and should be verified for correctness.
Workflow ID: wflow_qVzcCBZPxJsSq0hl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
PR Type
Enhancement
Description
Major changes to migrate from Cozo to PostgreSQL:
Changes walkthrough 📝
utils.py
Update import paths for database queries
agents-api/agents_api/activities/utils.py
create_doc.py
Remove document embedding workflow
agents-api/agents_api/routers/docs/create_doc.py
prepare_execution_input.py
Refactor execution input preparation query
agents-api/agents_api/queries/executions/prepare_execution_input.py
app.py
Update database configuration and middleware
agents-api/agents_api/app.py
env.py
Replace Cozo with PostgreSQL configuration
agents-api/agents_api/env.py