Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection within comments #5

Closed
Moltenhead opened this issue Feb 25, 2019 · 3 comments
Closed

Detection within comments #5

Moltenhead opened this issue Feb 25, 2019 · 3 comments

Comments

@Moltenhead
Copy link

Moltenhead commented Feb 25, 2019

Hi there.
Just to report that the extension is matching key words within commentaries and that's breaking the feature.

That's a cool idea though. :)

EDIT : forgot to tell it was within ruby (maybe something like (?<!<lang_comment_sign>))

@julien-duponchelle
Copy link
Owner

Yeah I'm aware of this issue I hope one day to be able to implement #1 same issue wit strings

I didn't found a proper way to implement it with regex, the best will be to implement a real parser and properly tokenize the file

@bjeanes
Copy link

bjeanes commented May 8, 2019

Even using regex, it should be possible to avoid detecting "do" in the word "don't" as here:

2019-05-08 at 1 13 pm

@polvalente
Copy link
Contributor

Maybe this issue can be closed now, @noplay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants