feat: implement ignore blocks #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polvalente
force-pushed
the
feat/ignore-blocks
branch
2 times, most recently
from
0b50716
to
c7ebd43
Compare
polvalente
commented
Aug 5, 2019
polvalente
commented
Aug 5, 2019
src/languages.ts
Outdated
| ], | ||
| neutralTokens: [ | ||
| "do", | ||
| " -> ", | ||
| " <- ", |
There was a problem hiding this comment.
I also had problems making this work. Maybe it's due to the way the Regexp is matched?
polvalente
force-pushed
the
feat/ignore-blocks
branch
6 times, most recently
from
c147036
to
aed0fbe
Compare
|
Back from holidays :) Can you also update the changelog and credit yourself inside it ? I will release the version after that . Thanks a lot it's awesome ! |
|
I'm making some final adjustments regarding the main RegExp call (because some things break due to boundary matching), and as soon as I'm done, I'll push again! |
…string text ignoring and improve elixir syntax matching feat: support other languages in ignore blocks
polvalente
force-pushed
the
feat/ignore-blocks
branch
from
aed0fbe
to
7154672
Compare
|
Done! |
|
Thanks a lot ! I will push a release in the coming days |
|
0.7 released 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for proper commented code and string text ignoring
Also, this PR improves the Elixir syntax matching
solves #4 and #5