Fix renaming a node to the name of its siblings breaking NodePath

Also fix cases where node name was not visually updated because name was not changed Co-Authored-By: Nông Văn Tình <[email protected]>
juliohq · Jan 16, 2024 · 2f69792 · 2f69792
1 parent 04eafd5
commit 2f69792
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/editor/gui/scene_tree_editor.cpp b/editor/gui/scene_tree_editor.cpp
@@ -1051,10 +1051,9 @@ void SceneTreeEditor::_rename_node(Node *p_node, const String &p_name) {
 		}
 	}
 
+	new_name = p_node->get_parent()->prevalidate_child_name(p_node, new_name);
 	if (new_name == p_node->get_name()) {
-		if (item->get_text(0).is_empty()) {
-			item->set_text(0, new_name);
-		}
+		item->set_text(0, new_name);
 		return;
 	}
 

diff --git a/scene/main/node.cpp b/scene/main/node.cpp
@@ -1214,6 +1214,11 @@ String Node::validate_child_name(Node *p_child) {
 	_generate_serial_child_name(p_child, name);
 	return name;
 }
+
+String Node::prevalidate_child_name(Node *p_child, StringName p_name) {
+	_generate_serial_child_name(p_child, p_name);
+	return p_name;
+}
 #endif
 
 String Node::adjust_name_casing(const String &p_name) {

diff --git a/scene/main/node.h b/scene/main/node.h
@@ -614,6 +614,7 @@ class Node : public Object {
 
 #ifdef TOOLS_ENABLED
 	String validate_child_name(Node *p_child);
+	String prevalidate_child_name(Node *p_child, StringName p_name);
 #endif
 	static String adjust_name_casing(const String &p_name);