Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #10

Merged
merged 7 commits into from
May 6, 2024
Merged

Code cleanup #10

merged 7 commits into from
May 6, 2024

Conversation

deflaux
Copy link
Collaborator

@deflaux deflaux commented May 2, 2024

Changes include:

  • Removed obsolete auth code now that all input data is public.
  • Deleted obsolete comments.
  • Prepped for getting this workflow and its Docker image into public places.

@deflaux deflaux requested review from dmikeando and amygdala May 2, 2024 20:39
@amygdala
Copy link
Collaborator

amygdala commented May 3, 2024

THANK YOU, Nicole!!
That looks great to me on a quick skim. I'll wait for Mike to take a look too.

One thing for us to remember: when we make the container image public, if we use GCP, we should use Artifact Registry this time, as Container Registry will be deprecated in less than a year.

Copy link
Collaborator

@dmikeando dmikeando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Nicole!

@deflaux deflaux merged commit d8325a1 into main May 6, 2024
1 check passed
@deflaux deflaux deleted the nd_repo_cleanup branch May 6, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants