Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference for maximization duals #149

Merged
merged 6 commits into from
Sep 28, 2022
Merged

Add reference for maximization duals #149

merged 6 commits into from
Sep 28, 2022

Conversation

joaquimg
Copy link
Member

first part of #142

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 93.30% // Head: 92.92% // Decreases project coverage by -0.37% ⚠️

Coverage data is based on head (619b6f6) compared to base (1c212ea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   93.30%   92.92%   -0.38%     
==========================================
  Files          12       12              
  Lines         702      622      -80     
==========================================
- Hits          655      578      -77     
+ Misses         47       44       -3     
Impacted Files Coverage Δ
src/MOI_wrapper.jl 91.77% <0.00%> (-0.89%) ⬇️
src/supported.jl 84.21% <0.00%> (-0.79%) ⬇️
src/dual_equality_constraints.jl 90.62% <0.00%> (-0.41%) ⬇️
src/objective_coefficients.jl 97.82% <0.00%> (-0.26%) ⬇️
src/dualize.jl 98.07% <0.00%> (-0.11%) ⬇️
src/dual_model_variables.jl 86.20% <0.00%> (-0.07%) ⬇️
src/utils.jl 100.00% <0.00%> (ø)
src/structures.jl 100.00% <0.00%> (ø)
src/constrained_variables.jl 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

test/runtests.jl Outdated
include("Solvers/csdp_test.jl")
include("Solvers/scs_test.jl")
# include("Solvers/highs_test.jl")
# include("Solvers/csdp_test.jl")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reenable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@blegat
Copy link
Member

blegat commented Sep 28, 2022

Maybe also write somewhere that for maximization, the dual can also be obtained by reversing the objective and using a min and then dualize.

@joaquimg joaquimg merged commit d9f9ee8 into master Sep 28, 2022
@odow odow deleted the jg/maxq branch April 12, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants